linux-kernel - Re: [PATCH v2 0/7] MODULE_LICENSE removals, first tranche

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y+5vczghnTF5nUut@spud>
Date:   Thu, 16 Feb 2023 18:01:23 +0000
From:   Conor Dooley <conor@...nel.org>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     Nick Alcock <nick.alcock@...cle.com>, mcgrof@...nel.org,
        linux-modules@...r.kernel.org, linux-kernel@...r.kernel.org,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Rob Herring <robh@...nel.org>,
        Shawn Guo <shawn.guo@...aro.org>,
        Karthikeyan Mitran <m.karthikeyan@...iveil.co.in>,
        Hou Zhiqiang <Zhiqiang.Hou@....com>,
        Thierry Reding <thierry.reding@...il.com>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Kishon Vijay Abraham I <kishon@...nel.org>,
        Leon Romanovsky <leon@...nel.org>,
        Jonathan Corbet <corbet@....net>,
        Hitomi Hasegawa <hasegawa-hitomi@...itsu.com>
Subject: Re: [PATCH v2 0/7] MODULE_LICENSE removals, first tranche

On Thu, Feb 16, 2023 at 11:43:33AM -0600, Bjorn Helgaas wrote:
> [+cc PCI folks, who got the patches but not this cover letter, and
> participants from the v1 posting]

Thanks Bjorn..

> On Thu, Feb 16, 2023 at 03:24:03PM +0000, Nick Alcock wrote:
> > This series, based on current modules-next, is part of a treewide cleanup
> > suggested by Luis Chamberlain, to remove the LICENSE_MODULE usage from
> > files/objects that are not tristate.  Due to recent changes to kbuild, these
> > uses are now problematic.  See the commit logs for more details.
> > 
> > (The commit log prefixes and Cc lists are automatically determined using
> > the script mentioned below.  I've eyeballed them, and they seem reasonable:
> > my apologies if they are not.)
> > 
> > This is a small initial tranche to see if the general approach is valid:
> > larger tranches can follow if desired and if these patches seem OK.
> > I'll be sending a second 24-patch tranche in a few hours if this
> > one meets with general approval.
> > 
> > (In total, there are 121 patches in this series.)
> > 
> > 
> > Differences from v1:
> >  - just remove MODULE_LICENSE, don't comment it out
> >  - Cc: paid maintainers as well as unpaid ones
> >  - improvements to the prefix determination code (notable in
> >    PCI: versatile in particular)
> > 
> > The series at a whole can be found here:
> >   https://github.com/nickalcock/linux module-license
> > 
> > The patch splitter (not for upstreaming!) used to prepare these
> > commits can be found here:
> >   https://github.com/nickalcock/linux mass-split
> > 
> > Cc: Luis Chamberlain <mcgrof@...nel.org>
> > Cc: linux-modules@...r.kernel.org
> > Cc: linux-kernel@...r.kernel.org
> > 
> > Nick Alcock (7):
> >   kbuild, PCI: versatile: remove MODULE_LICENSE in non-modules
> >   kbuild, PCI: mobiveil: remove MODULE_LICENSE in non-modules
> >   kbuild, PCI: tegra: remove MODULE_LICENSE in non-modules
> >   kbuild, PCI: endpoint: remove MODULE_LICENSE in non-modules
> >   kbuild, PCI: hip: remove MODULE_LICENSE in non-modules
> >   kbuild, shpchp: remove MODULE_LICENSE in non-modules
> >   kbuild, PCI: dwc: remove MODULE_LICENSE in non-modules
> > 
> >  drivers/pci/controller/dwc/pcie-histb.c              | 1 -
> >  drivers/pci/controller/mobiveil/pcie-mobiveil-plat.c | 1 -
> >  drivers/pci/controller/pci-tegra.c                   | 1 -
> >  drivers/pci/controller/pci-versatile.c               | 1 -
> >  drivers/pci/controller/pcie-hisi-error.c             | 1 -
> >  drivers/pci/endpoint/pci-ep-cfs.c                    | 1 -
> >  drivers/pci/endpoint/pci-epc-core.c                  | 1 -
> >  drivers/pci/endpoint/pci-epc-mem.c                   | 1 -
> >  drivers/pci/endpoint/pci-epf-core.c                  | 1 -
> >  drivers/pci/hotplug/shpchp_core.c                    | 1 -
> >  10 files changed, 10 deletions(-)
> 
> I squashed these and applied to pci/kbuild for v6.3, thanks!
> 
> I added examples from the v1 posting to the commit log; let me know if
> I got anything wrong:

I noticed that (as requested!) Nick dropped the change to the microchip
driver.
Would you like me to resend patch 3/11 of [1] to clear the decks of
"incorrect" MODULE_LICENSE usage?

Thanks,
Conor.

1 - https://lore.kernel.org/linux-pci/20230111125323.1911373-4-daire.mcnamara@microchip.com/

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)