linux-kernel - Re: [PATCH v2 1/1] ufs: mcq: fix incorrectly set queue depth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230216180922.GA7015@thinkpad>
Date:   Thu, 16 Feb 2023 23:39:22 +0530
From:   Manivannan Sadhasivam <mani@...nel.org>
To:     Asutosh Das <quic_asutoshd@...cinc.com>
Cc:     quic_cang@...cinc.com, martin.petersen@...cle.com,
        linux-scsi@...r.kernel.org, quic_nguyenb@...cinc.com,
        quic_xiaosenh@...cinc.com, stanley.chu@...iatek.com,
        adrian.hunter@...el.com, bvanassche@....org, avri.altman@....com,
        mani@...nel.org, beanhuo@...ron.com, linux-arm-msm@...r.kernel.org,
        Alim Akhtar <alim.akhtar@...sung.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/1] ufs: mcq: fix incorrectly set queue depth

On Thu, Feb 16, 2023 at 09:13:46AM -0800, Asutosh Das wrote:
> ufshcd_config_mcq() may change the can_queue value.
> The current code invokes scsi_add_host() before ufshcd_config_mcq().
> So the tags are limited to the old can_queue value.
> 
> Fix this by invoking scsi_add_host() after ufshcd_config_mcq().
> 
> Fixes: 2468da61ea09 ("scsi: ufs: core: mcq: Configure operation and runtime interface")
> Signed-off-by: Asutosh Das <quic_asutoshd@...cinc.com>

Reviewed-by: Manivannan Sadhasivam <mani@...nel.org>

Thanks,
Mani

> 
> ----
> v1 -> v2:
>   - Added Fixes tag
>   - Reworked to handle success case first
> ---
>  drivers/ufs/core/ufshcd.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index 3b3cf78d3b10..3891183897f0 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -8530,7 +8530,9 @@ static int ufshcd_device_init(struct ufs_hba *hba, bool init_dev_params)
>  			return ret;
>  		if (is_mcq_supported(hba) && !hba->scsi_host_added) {
>  			ret = ufshcd_alloc_mcq(hba);
> -			if (ret) {
> +			if (!ret) {
> +				ufshcd_config_mcq(hba);
> +			} else {
>  				/* Continue with SDB mode */
>  				use_mcq_mode = false;
>  				dev_err(hba->dev, "MCQ mode is disabled, err=%d\n",
> @@ -8542,10 +8544,10 @@ static int ufshcd_device_init(struct ufs_hba *hba, bool init_dev_params)
>  				return ret;
>  			}
>  			hba->scsi_host_added = true;
> -		}
> -		/* MCQ may be disabled if ufshcd_alloc_mcq() fails */
> -		if (is_mcq_supported(hba) && use_mcq_mode)
> +		} else if (is_mcq_supported(hba)) {
> +			/* UFSHCD_QUIRK_REINIT_AFTER_MAX_GEAR_SWITCH is set */
>  			ufshcd_config_mcq(hba);
> +		}
>  	}
>  
>  	ufshcd_tune_unipro_params(hba);
> -- 
> 2.7.4
> 

-- 
மணிவண்ணன் சதாசிவம்