linux-kernel - Re: [PATCH v4 1/5] i2c: hpe: Add GXP SoC I2C Controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y+6WZT4KtqQ2Wg9o@ninjato>
Date:   Thu, 16 Feb 2023 21:47:33 +0100
From:   Wolfram Sang <wsa@...nel.org>
To:     "Hawkins, Nick" <nick.hawkins@....com>
Cc:     "Verdun, Jean-Marie" <verdun@....com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "joel@....id.au" <joel@....id.au>
Subject: Re: [PATCH v4 1/5] i2c: hpe: Add GXP SoC I2C Controller

Hi Nick,

> I will work on the defines and get rid of all the magic values.

Cool, thank you!

> Unfortunately, there is no public spec available currently.
> Hopefully, we will have one someday though.

Then, the #defines are even more helpful!

> > drivers/i2c/busses/i2c-gxp.c: In function ‘gxp_i2c_probe’:
> > drivers/i2c/busses/i2c-gxp.c:533:28: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
> > 533 | drvdata->engine = ((u32)drvdata->base & 0xf00) >> 8;
> 
> I am currently unable to reproduce this error. I even set W=2.

Interesting. I have this version:

gcc (Debian 10.2.1-6) 10.2.1 20210110

> Would replacing (u32) with (unsigned long) resolve it?

Or size_t.

Happy hacking,

   Wolfram

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)