linux-kernel - Re: [PATCH v4 05/11] iommu/mediatek: mt8192: Add iova_region_larb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b15c64dede5dd18b358583ac135607d6b43c46d1.camel@mediatek.com>
Date:   Thu, 16 Feb 2023 05:27:04 +0000
From:   Yong Wu (吴勇) <Yong.Wu@...iatek.com>
To:     "joro@...tes.org" <joro@...tes.org>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>
CC:     "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Youlin Pei (裴友林) 
        <youlin.pei@...iatek.com>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Jianjiao Zeng (曾健姣) 
        <Jianjiao.Zeng@...iatek.com>,
        Anan Sun (孙安安) <Anan.Sun@...iatek.com>,
        "kyrie.wu@...iatek.corp-partner.google.com" 
        <kyrie.wu@...iatek.corp-partner.google.com>,
        "robin.murphy@....com" <robin.murphy@....com>,
        "hverkuil@...all.nl" <hverkuil@...all.nl>,
        Chengci Xu (许承赐) 
        <Chengci.Xu@...iatek.com>,
        Yunfei Dong (董云飞) 
        <Yunfei.Dong@...iatek.com>,
        YF Wang (王云飞) <YF.Wang@...iatek.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
        Mingyuan Ma (马鸣远) 
        <Mingyuan.Ma@...iatek.com>, "will@...nel.org" <will@...nel.org>,
        "nfraprado@...labora.com" <nfraprado@...labora.com>
Subject: Re: [PATCH v4 05/11] iommu/mediatek: mt8192: Add iova_region_larb_msk

On Wed, 2023-02-15 at 13:33 +0100, AngeloGioacchino Del Regno wrote:
> Il 15/02/23 07:25, Yong Wu ha scritto:
> > Add iova_region_larb_msk for mt8192. We separate the 16GB iova
> > regions
> > by each device's larbid/portid.
> > Note: larb3/6/8/10/12/15 connect nothing in this SoC.
> > Refer to the comment in include/dt-bindings/memory/mt8192-larb-
> > port.h
> > 
> > Define a new macro MT8192_MULTI_REGION_NR_MAX to indicate
> > the index of mt8xxx_larb_region_msk and
> > "struct mtk_iommu_iova_region mt8192_multi_dom"
> > are the same.
> > 
> > Signed-off-by: Yong Wu <yong.wu@...iatek.com>
> 
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@...labora.com>
> 
> P.S.: I'm sorry for the step-by-step review and making you send
> multiple versions,
>        I feel this can be tedious sometimes but - at times - this is
> the only way
>        to make sure that the code is as "beautiful" and bug-free as
> possible!

You are too kind. This should be all we need to thank you for always
help us with a careful review, every clear and careful reply benefit us
a lot.
Many thanks.

> 
> Cheers!