linux-kernel - Re: [PATCH v4 06/10] soc: fsl: cmp1: Add support for QMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a5a2ab44-2ec8-66a1-b249-88e41d3a30f9@csgroup.eu>
Date:   Thu, 16 Feb 2023 06:43:54 +0000
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     Leo Li <leoyang.li@....com>,
        Herve Codina <herve.codina@...tlin.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Nicholas Piggin <npiggin@...il.com>,
        Qiang Zhao <qiang.zhao@....com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Shengjiu Wang <shengjiu.wang@...il.com>,
        Xiubo Li <Xiubo.Lee@...il.com>,
        Fabio Estevam <festevam@...il.com>,
        Nicolin Chen <nicoleotsuka@...il.com>
CC:     "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v4 06/10] soc: fsl: cmp1: Add support for QMC



Le 15/02/2023 à 23:44, Leo Li a écrit :
> 
> 
>> -----Original Message-----
>> From: Herve Codina <herve.codina@...tlin.com>
>> Sent: Thursday, January 26, 2023 2:32 AM
>> To: Herve Codina <herve.codina@...tlin.com>; Leo Li
>> <leoyang.li@....com>; Rob Herring <robh+dt@...nel.org>; Krzysztof
>> Kozlowski <krzysztof.kozlowski+dt@...aro.org>; Liam Girdwood
>> <lgirdwood@...il.com>; Mark Brown <broonie@...nel.org>; Christophe
>> Leroy <christophe.leroy@...roup.eu>; Michael Ellerman
>> <mpe@...erman.id.au>; Nicholas Piggin <npiggin@...il.com>; Qiang Zhao
>> <qiang.zhao@....com>; Jaroslav Kysela <perex@...ex.cz>; Takashi Iwai
>> <tiwai@...e.com>; Shengjiu Wang <shengjiu.wang@...il.com>; Xiubo Li
>> <Xiubo.Lee@...il.com>; Fabio Estevam <festevam@...il.com>; Nicolin
>> Chen <nicoleotsuka@...il.com>
>> Cc: linuxppc-dev@...ts.ozlabs.org; linux-arm-kernel@...ts.infradead.org;
>> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; alsa-devel@...a-
>> project.org; Thomas Petazzoni <thomas.petazzoni@...tlin.com>
>> Subject: [PATCH v4 06/10] soc: fsl: cmp1: Add support for QMC
> 
> Typo: cpm1
> 
>>
>> The QMC (QUICC Multichannel Controller) emulates up to 64 channels within
>> one serial controller using the same TDM physical interface routed from the
>> TSA.
>>
>> It is available in some	PowerQUICC SoC such as the
>> MPC885 or MPC866.
>>
>> It is also available on some Quicc Engine SoCs.
>> This current version support CPM1 SoCs only and some enhancement are
>> needed to support Quicc Engine SoCs.
>>
>> Signed-off-by: Herve Codina <herve.codina@...tlin.com>
> 
> Otherwise looks good to me.
> 
> Acked-by: Li Yang <leoyang.li@....com>

Thanks for the review and the ack.

Were you also able to have a look at patch 2 which implements support 
for the timeslot assigner (TSA) ?

Christophe