linux-kernel - Re: [PATCH net-next v2 06/10] net: microchip: sparx5: Add ES0 VCAP model and updated KUNIT VCAP model

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e3ab2825bcb0ae93fd26a35dcaee91224ecadc0b.camel@microchip.com>
Date:   Thu, 16 Feb 2023 10:07:48 +0100
From:   Steen Hegelund <steen.hegelund@...rochip.com>
To:     Paolo Abeni <pabeni@...hat.com>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>
CC:     <UNGLinuxDriver@...rochip.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Casper Andersson <casper.casan@...il.com>,
        Russell King <rmk+kernel@...linux.org.uk>,
        Wan Jiabing <wanjiabing@...o.com>,
        "Nathan Huckleberry" <nhuck@...gle.com>,
        <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        "Daniel Machon" <daniel.machon@...rochip.com>,
        Horatiu Vultur <horatiu.vultur@...rochip.com>,
        Lars Povlsen <lars.povlsen@...rochip.com>,
        Dan Carpenter <error27@...il.com>,
        Michael Walle <michael@...le.cc>
Subject: Re: [PATCH net-next v2 06/10] net: microchip: sparx5: Add ES0 VCAP
 model and updated KUNIT VCAP model

Hi Paolo,

On Thu, 2023-02-16 at 09:09 +0100, Paolo Abeni wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> On Tue, 2023-02-14 at 11:40 +0100, Steen Hegelund wrote:
> > This provides the VCAP model for the Sparx5 ES0 (Egress Stage 0) VCAP.
> > 
> > This VCAP provides rewriting functionality in the egress path.
> > 
> > Signed-off-by: Steen Hegelund <steen.hegelund@...rochip.com>
> > ---
> >  .../microchip/sparx5/sparx5_vcap_ag_api.c     | 385 +++++++++++++++++-
> >  .../net/ethernet/microchip/vcap/vcap_ag_api.h | 174 +++++++-
> >  .../microchip/vcap/vcap_api_debugfs_kunit.c   |   4 +-
> >  .../microchip/vcap/vcap_model_kunit.c         | 270 +++++++-----
> >  .../microchip/vcap/vcap_model_kunit.h         |  10 +-
> >  5 files changed, 721 insertions(+), 122 deletions(-)
> > 
> > diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_vcap_ag_api.c
> > b/drivers/net/ethernet/microchip/sparx5/sparx5_vcap_ag_api.c
> > index 561001ee0516..556d6ea0acd1 100644
> > --- a/drivers/net/ethernet/microchip/sparx5/sparx5_vcap_ag_api.c
> > +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_vcap_ag_api.c
> > @@ -3,8 +3,8 @@
> >   * Microchip VCAP API
> >   */
> > 
> > -/* This file is autogenerated by cml-utils 2023-01-17 16:55:38 +0100.
> > - * Commit ID: cc027a9bd71002aebf074df5ad8584fe1545e05e
> > +/* This file is autogenerated by cml-utils 2023-02-10 11:15:56 +0100.
> > + * Commit ID: c30fb4bf0281cd4a7133bdab6682f9e43c872ada
> >   */
> 
> If the following has been already discussed, I'm sorry for the
> duplicates, I missed the relevant thread.
> 
> Since this drivers contains quite a bit of auto-generated code, I'm
> wondering if you could share the tool and/or the source file, too. That
> would make reviews more accurate.

So far we have not made the tool (CML-Utils) available online, but it is
included as zip archive in our quarterly BSP releases which are available on
AWS.

The BSP uses it (via Buildroot) to generate register access header files and
VCAP models as well as compiling various test tools that are added to the
rootfs.

It is not because we want CML-Utils to be secret that it is not online, but
rather that we want to be free to update/change/remove features as needed
without breaking any build processes that might have been relying on these
features with our customers.

I would expect that CML-Utils will eventually have its own public repo, but it
is probably a little too early yet. 

> 
> Thanks,
> 
> Paolo
> 

BR
Steen