linux-kernel - Re: [PATCH] i2c: xiic: Remove some dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Feb 2023 10:12:57 +0100
From:   Michal Simek <michal.simek@....com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Michal Simek <michal.simek@...inx.com>
CC:     <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <linux-i2c@...r.kernel.org>
Subject: Re: [PATCH] i2c: xiic: Remove some dead code



On 2/15/23 11:38, Christophe JAILLET wrote:
> 
> wait_for_completion_timeout() never returns negative value.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>   drivers/i2c/busses/i2c-xiic.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
> index 8503b5016aaf..5543f372ae60 100644
> --- a/drivers/i2c/busses/i2c-xiic.c
> +++ b/drivers/i2c/busses/i2c-xiic.c
> @@ -1038,10 +1038,6 @@ static int xiic_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
>                  i2c->rx_msg = NULL;
>                  i2c->nmsgs = 0;
>                  err = -ETIMEDOUT;
> -       } else if (err < 0) {   /* Completion error */
> -               i2c->tx_msg = NULL;
> -               i2c->rx_msg = NULL;
> -               i2c->nmsgs = 0;
>          } else {
>                  err = (i2c->state == STATE_DONE) ? num : -EIO;
>          }
> --
> 2.34.1
> 

Reviewed-by: Michal Simek <michal.simek@....com>

Thanks,
Michal