linux-kernel - Re: [PATCH 1/2] pcmcia : make PCMCIA depend on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <2c8d97ad-126d-4912-b4eb-37437d8c3407@app.fastmail.com>
Date:   Thu, 16 Feb 2023 10:37:03 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Niklas Schnelle" <schnelle@...ux.ibm.com>,
        "Baoquan He" <bhe@...hat.com>, linux-kernel@...r.kernel.org
Cc:     linux-mm@...ck.org, linux-s390@...r.kernel.org,
        "Dominik Brodowski" <linux@...inikbrodowski.net>,
        "Jonathan Cameron" <Jonathan.Cameron@...wei.com>,
        "Linus Walleij" <linus.walleij@...aro.org>,
        "Thomas Bogendoerfer" <tsbogend@...ha.franken.de>
Subject: Re: [PATCH 1/2] pcmcia : make PCMCIA depend on HAS_IOMEM

On Thu, Feb 16, 2023, at 10:05, Niklas Schnelle wrote:
> On Thu, 2023-02-16 at 15:34 +0800, Baoquan He wrote:
>> diff --git a/drivers/pcmcia/Kconfig b/drivers/pcmcia/Kconfig
>> index 1525023e49b6..7c412bbe8bbe 100644
>> --- a/drivers/pcmcia/Kconfig
>> +++ b/drivers/pcmcia/Kconfig
>> @@ -20,6 +20,7 @@ if PCCARD
>>  
>>  config PCMCIA
>>  	tristate "16-bit PCMCIA support"
>> +	depends on HAS_IOMEM
>>  	select CRC32
>>  	default y
>>  	help
>
> Not sure how many PCMCIA drivers only use I/O memory but not I/O ports
> the latter of which are badly stubbed out on s390, though at leat they
> compile. I have a series on that part that I intend to send a new
> version for soon™. That said yes this does solve the compilation issue
> and there could be drivers which rely only on I/O memory and are not
> broken in principle.

There are no platforms that have I/O ports but don't set HAS_IOMEM, so it
doesn't really matter.

> Reviewed-by: Niklas Schnelle <schnelle@...ux.ibm.com>

Acked-by: Arnd Bergmann <arnd@...db.de>