linux-kernel - Re: [PATCH] power: reset: at91-poweroff: Use devm_platform_get_and_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <188f341c-cc4e-16ae-d551-184bb48f09da@microchip.com>
Date:   Thu, 16 Feb 2023 10:01:29 +0000
From:   <Claudiu.Beznea@...rochip.com>
To:     <ye.xingchen@....com.cn>, <sre@...nel.org>
CC:     <Nicolas.Ferre@...rochip.com>, <alexandre.belloni@...tlin.com>,
        <linux-pm@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] power: reset: at91-poweroff: Use devm_platform_get_and_ioremap_resource()

On 15.02.2023 08:49, ye.xingchen@....com.cn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> From: Ye Xingchen <ye.xingchen@....com.cn>
> 
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Signed-off-by: Ye Xingchen <ye.xingchen@....com.cn>

Reviewed-by: Claudiu Beznea <claudiu.beznea@...rochip.com>


> ---
>  drivers/power/reset/at91-poweroff.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/power/reset/at91-poweroff.c b/drivers/power/reset/at91-poweroff.c
> index 9e74e131c675..b7e17afe30e2 100644
> --- a/drivers/power/reset/at91-poweroff.c
> +++ b/drivers/power/reset/at91-poweroff.c
> @@ -151,13 +151,11 @@ static void at91_poweroff_dt_set_wakeup_mode(struct platform_device *pdev)
> 
>  static int __init at91_poweroff_probe(struct platform_device *pdev)
>  {
> -       struct resource *res;
>         struct device_node *np;
>         u32 ddr_type;
>         int ret;
> 
> -       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -       at91_shdwc.shdwc_base = devm_ioremap_resource(&pdev->dev, res);
> +       at91_shdwc.shdwc_base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
>         if (IS_ERR(at91_shdwc.shdwc_base))
>                 return PTR_ERR(at91_shdwc.shdwc_base);
> 
> --
> 2.25.1