linux-kernel - Re: [PATCH v5 1/2] usb: serial: add support for CH348

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y+4Fpd0lcJkQrXef@kroah.com>
Date:   Thu, 16 Feb 2023 11:29:57 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Johan Hovold <johan@...nel.org>
Cc:     Corentin Labbe <clabbe@...libre.com>, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH v5 1/2] usb: serial: add support for CH348

On Thu, Feb 16, 2023 at 10:14:57AM +0100, Johan Hovold wrote:
> > +	if (urb->actual_length < 2) {
> > +		dev_dbg(&port->dev, "%s:%d empty rx buffer\n", __func__, __LINE__);
> 
> I'm sure I've asked you drop __LINE__. Please be more careful when
> considering review comments.

FYI, __func__ and __LINE__ are included automatically in dev_dbg() calls
so any addition in the string for them is redundant and should never be
there (it's also a hint that no one used this debug statement as the
redundancy would be kind of obvious...)

thanks,

greg k-h