linux-kernel - Re: [PATCH 1/2] dt-bindings: regulator: Add bindings for Richtek RT5739

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2fecab8a-26ae-c62d-bf47-7319e11bbe51@linaro.org>
Date:   Thu, 16 Feb 2023 11:45:05 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     ChiYuan Huang <cy_huang@...htek.com>
Cc:     broonie@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, lgirdwood@...il.com,
        u0084500@...il.com, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: regulator: Add bindings for Richtek
 RT5739

On 16/02/2023 11:35, ChiYuan Huang wrote:

> https://elixir.bootlin.com/linux/v6.2-rc8/source/drivers/regulator/of_regulator.c#L198
> It seems no need to limit the maxItems. Regulator core will call 'of_map_mode' to check the value.
> Even the value is repeat.
> 
> And for minItems, 'regulator.yaml' already said it's uint32-array. Must be lager than zero, right?
> 
> So how about just keep 'items' and remove the 'maxItems'?

Yeah, go ahead, with that enum, it should be correct..

Best regards,
Krzysztof