linux-kernel - Re: [PATCH v2 1/2] mm/memory_hotplug: return nothing from do_migrate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <af96ecf7-3039-784d-c276-5fc6b72611c4@linux.alibaba.com>
Date:   Thu, 16 Feb 2023 18:53:34 +0800
From:   Baolin Wang <baolin.wang@...ux.alibaba.com>
To:     SeongJae Park <sj@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     David Hildenbrand <david@...hat.com>,
        Oscar Salvador <osalvador@...e.de>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] mm/memory_hotplug: return nothing from
 do_migrate_range()



On 2/16/2023 7:02 AM, SeongJae Park wrote:
> Return value mechanism of do_migrate_range() is not very simple, while
> no caller of the function checks the return value.  Make the function
> return nothing to be more simple.
> 
> Suggested-by: David Hildenbrand <david@...hat.com>
> Signed-off-by: SeongJae Park <sj@...nel.org>
> ---
>   mm/memory_hotplug.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index bcb0dc41c2f2..6c615ba1a5c7 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -1620,8 +1620,7 @@ static int scan_movable_pages(unsigned long start, unsigned long end,
>   	return 0;
>   }
>   
> -static int
> -do_migrate_range(unsigned long start_pfn, unsigned long end_pfn)
> +static void do_migrate_range(unsigned long start_pfn, unsigned long end_pfn)
>   {
>   	unsigned long pfn;
>   	struct page *page, *head;
> @@ -1721,8 +1720,6 @@ do_migrate_range(unsigned long start_pfn, unsigned long end_pfn)
>   			putback_movable_pages(&source);
>   		}
>   	}
> -
> -	return ret;

Nit: while we are at it, can we also remove the "TODO" comment in 
offline_pages()?

ret = scan_movable_pages(pfn, end_pfn, &pfn);
if (!ret) {
	/*
	 * TODO: fatal migration failures should bail
	 * out
	 */
	do_migrate_range(pfn, end_pfn);
}

With David's comments:
Reviewed-by: Baolin Wang <baolin.wang@...ux.alibaba.com>