linux-kernel - Re: [PATCH] hid: bigben_probe(): validate report count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <167654718338.255038.8270814886921394655.b4-ty@redhat.com>
Date:   Thu, 16 Feb 2023 12:33:03 +0100
From:   Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:     Jiri Kosina <jikos@...nel.org>, Hanno Zulla <abos@...no.de>,
        Pietro Borrello <borrello@...g.uniroma1.it>
Cc:     Jiri Kosina <jkosina@...e.cz>, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hid: bigben_probe(): validate report count


On Sun, 12 Feb 2023 00:01:44 +0000, Pietro Borrello wrote:
> bigben_probe() does not validate that the output report has the
> needed report values in the first field.
> A malicious device registering a report with one field and a single
> value causes an head OOB write in bigben_worker() when
> accessing report_field->value[1] to report_field->value[7].
> Use hid_validate_values() which takes care of all the needed checks.
> 
> [...]

Applied, thanks!

[1/1] hid: bigben_probe(): validate report count
      commit: b94335f899542a0da5fafc38af8edcaf90195843

Best regards,
-- 
Benjamin Tissoires <benjamin.tissoires@...hat.com>