linux-kernel - Re: [PATCH 2/2] HID: apple-magic-backlight: Add driver for keyboard backlight on internal Magic Keyboards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VeX0j8ZX+j0i7qPe97NcyFLvhmETFCbRVYiVCFQWk8Akg@mail.gmail.com>
Date:   Thu, 16 Feb 2023 13:49:21 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Orlando Chamberlain <orlandoch.dev@...il.com>
Cc:     linux-input@...r.kernel.org, Jonathan Corbet <corbet@....net>,
        Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Pavel Machek <pavel@....cz>,
        Aditya Garg <gargaditya08@...e.com>,
        Aun-Ali Zaidi <admin@...eit.net>,
        Kerem Karabay <kekrby@...il.com>,
        Andy Shevchenko <andy@...radead.org>,
        Thomas Weißschuh <thomas@...ch.de>
Subject: Re: [PATCH 2/2] HID: apple-magic-backlight: Add driver for keyboard
 backlight on internal Magic Keyboards

On Thu, Feb 16, 2023 at 10:15 AM Orlando Chamberlain
<orlandoch.dev@...il.com> wrote:
> On Thu, 16 Feb 2023 15:12:28 +1100
> Orlando Chamberlain <orlandoch.dev@...il.com> wrote:

...

> >  drivers/hid/apple-magic-backlight.c | 125
>
> A general question to the hid/input folks:
>
> Is it alright that this doesn't start with "hid-"? All the other
> drivers start with that so I'm not sure if its an issue.

What makes apple so special?

> If it is, then
> I can rename it to "hid-apple-magic-backlight".

If there is a good justification of not doing that, put it into the
commit message.

-- 
With Best Regards,
Andy Shevchenko