linux-kernel - Re: [PATCH v2 2/3] Input: add ABS_SND

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <952d1e7c-8f46-086a-8e14-fa225c6f5844@irl.hu>
Date:   Thu, 16 Feb 2023 03:22:59 +0100
From:   Gergo Koteles <soyer@....hu>
To:     Pavel Machek <pavel@....cz>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Jonathan Corbet <corbet@....net>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        Caleb Connolly <caleb@...nolly.tech>
Subject: Re: [PATCH v2 2/3] Input: add ABS_SND_PROFILE

Hi Pavel,
> Hi!
> 
>> ABS_SND_PROFILE used to describe the state of a multi-value sound profile
>> switch. This will be used for the tri-state key on OnePlus phones or other
>> phones.
> 
> Looks like ABS_PROFILE would be fine to use there, no need to create
> new one, no?
> 

ABS_PROFILE used by some Xbox game controllers to switch controller 
profiles. In the future, it's imaginable to play games in a linux mobile 
with the controllers. If we don't want to know in userspace where the 
event comes from, I think ABS_SND_PROFILE would be better.

Thanks,
Gergo

> Best regards,
> 								Pavel
> 
>> Signed-off-by: Gergo Koteles <soyer@....hu>
>> ---
>>   Documentation/input/event-codes.rst    | 6 ++++++
>>   drivers/hid/hid-debug.c                | 1 +
>>   include/uapi/linux/input-event-codes.h | 1 +
>>   3 files changed, 8 insertions(+)
>>
>> diff --git a/Documentation/input/event-codes.rst b/Documentation/input/event-codes.rst
>> index b4557462edd7..d43336e64d6a 100644
>> --- a/Documentation/input/event-codes.rst
>> +++ b/Documentation/input/event-codes.rst
>> @@ -241,6 +241,12 @@ A few EV_ABS codes have special meanings:
>>       emitted only when the selected profile changes, indicating the newly
>>       selected profile value.
>>   
>> +* ABS_SND_PROFILE:
>> +
>> +  - Used to describe the state of a multi-value sound profile switch.
>> +    An event is emitted only when the selected profile changes,
>> +    indicating the newly selected profile value.
>> +
>>   * ABS_MT_<name>:
>>   
>>     - Used to describe multitouch input events. Please see
>> diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c
>