linux-kernel - Re: [PATCH v4 01/16] hexagon: mm: Convert to GENERIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <f93fdb4e-05e0-4301-95c9-3e1b1200d9b2@app.fastmail.com>
Date:   Thu, 16 Feb 2023 15:51:50 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Baoquan He" <bhe@...hat.com>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        "Andrew Morton" <akpm@...ux-foundation.org>,
        "Christophe Leroy" <christophe.leroy@...roup.eu>,
        "Christoph Hellwig" <hch@...radead.org>,
        "Alexander Gordeev" <agordeev@...ux.ibm.com>,
        "Kefeng Wang" <wangkefeng.wang@...wei.com>,
        "Niklas Schnelle" <schnelle@...ux.ibm.com>,
        "David Laight" <David.Laight@...lab.com>,
        "Stafford Horne" <shorne@...il.com>,
        "Brian Cain" <bcain@...cinc.com>, linux-hexagon@...r.kernel.org
Subject: Re: [PATCH v4 01/16] hexagon: mm: Convert to GENERIC_IOREMAP

On Thu, Feb 16, 2023, at 15:47, Baoquan He wrote:
> On 02/16/23 at 01:53pm, Arnd Bergmann wrote:
>> On Thu, Feb 16, 2023, at 13:34, Baoquan He wrote:
>> I see that there are only two callers of {devm_,}ioremap_uc() left in the
>> tree, so maybe we can even take that final step and remove it from
>> the interface. Maybe we can revisit [1] as part of this series.
>
> I see now. Christoph Hellwig ever mentioned in v2 reviewing, I
> didn't get why. Thanks for the details. 
> https://lore.kernel.org/all/YwHX98KBEnZw9t6e@infradead.org/T/#u
>
> I am not sure if it's OK to do the change in this patchset, maybe
> another patch?

Yes, a separate patch would be ideal. If you do the same change in
more than one architecture (other than ia64 and x86), you can combine
those into one patch.

    Arnd