linux-kernel - Re: [PATCH v4 12/16] parisc: mm: Convert to GENERIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <bff4f286-ccf8-40bc-8fe5-d4041adf89f5@app.fastmail.com>
Date:   Thu, 16 Feb 2023 16:18:53 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Baoquan He" <bhe@...hat.com>,
        "Matthew Wilcox" <willy@...radead.org>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        "Andrew Morton" <akpm@...ux-foundation.org>,
        "Christophe Leroy" <christophe.leroy@...roup.eu>,
        "Christoph Hellwig" <hch@...radead.org>,
        "Alexander Gordeev" <agordeev@...ux.ibm.com>,
        "Kefeng Wang" <wangkefeng.wang@...wei.com>,
        "Niklas Schnelle" <schnelle@...ux.ibm.com>,
        "David Laight" <David.Laight@...lab.com>,
        "Stafford Horne" <shorne@...il.com>,
        "James E . J . Bottomley" <James.Bottomley@...senpartnership.com>,
        "Helge Deller" <deller@....de>, linux-parisc@...r.kernel.org
Subject: Re: [PATCH v4 12/16] parisc: mm: Convert to GENERIC_IOREMAP

On Thu, Feb 16, 2023, at 16:02, Baoquan He wrote:
> On 02/16/23 at 01:50pm, Matthew Wilcox wrote:
> It's not if including asm-generic/iomap.h. The ARCH_HAS_IOREMAP_xx is to
> avoid redefinition there.
>
> include/asm-generic/iomap.h:
> ----
> #ifndef ARCH_HAS_IOREMAP_WC
> #define ioremap_wc ioremap
> #endif

I'd change that to the usual '#ifndef ioremap_wc' in that case.

      Arnd