linux-kernel - Re: [PATCH 8/9] ASoC: amd: vangogh: Centralize strings definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 16 Feb 2023 15:37:20 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Lucas Tanure <lucas.tanure@...labora.com>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Vijendar Mukunda <Vijendar.Mukunda@....com>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        kernel@...labora.com
Subject: Re: [PATCH 8/9] ASoC: amd: vangogh: Centralize strings definition

On Thu, Feb 16, 2023 at 10:32:59AM +0000, Lucas Tanure wrote:

> Replace occurrences of strings by their definition, avoiding bugs where
> the string changed, but not all places have been modified

>  #define DRV_NAME			"acp5x_mach"
>  #define DUAL_CHANNEL			2
> -#define ACP5X_NUVOTON_CODEC_DAI		"nau8821-hifi"
>  #define VG_JUPITER			1
> -#define ACP5X_NUVOTON_BCLK		3072000
> -#define ACP5X_NAU8821_FREQ_OUT		12288000
> +#define NAU8821_BCLK			3072000
> +#define NAU8821_FREQ_OUT		12288000
> +#define NAU8821_DAI			"nau8821-hifi"
> +#define CS35L41_LNAME			"spi-VLV1776:00"
> +#define CS35L41_RNAME			"spi-VLV1776:01"
> +#define CS35L41_DAI			"cs35l41-pcm"

These changes don't obviously correspond to the description of
the patch.  It looks like there's at least some renaming and
reindentation of things not related to DAI names here.  TBH I'm
not sure the removal of namespacing is a good idea, it's probably
not *super* likely but we might run into collisions.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)