linux-kernel - Re: [PATCH v2] eventfd: use wait_event_interruptible_locked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y+74gAWLLOu4mNhC@sol.localdomain>
Date:   Thu, 16 Feb 2023 19:46:08 -0800
From:   Eric Biggers <ebiggers@...nel.org>
To:     wenyang.linux@...mail.com
Cc:     Alexander Viro <viro@...iv.linux.org.uk>,
        Christoph Hellwig <hch@....de>, Dylan Yudaken <dylany@...com>,
        Jens Axboe <axboe@...nel.dk>,
        David Woodhouse <dwmw@...zon.co.uk>, Fu Wei <wefu@...hat.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Michal Nazarewicz <m.nazarewicz@...sung.com>,
        Matthew Wilcox <willy@...radead.org>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] eventfd: use wait_event_interruptible_locked_irq()
 helper

On Fri, Feb 17, 2023 at 02:29:48AM +0800, wenyang.linux@...mail.com wrote:
> From: Wen Yang <wenyang.linux@...mail.com>
> 
> wait_event_interruptible_locked_irq was introduced by commit 22c43c81a51e
> ("wait_event_interruptible_locked() interface"), but older code such as
> eventfd_{write,read} still uses the open code implementation.
> Inspired by commit 8120a8aadb20
> ("fs/timerfd.c: make use of wait_event_interruptible_locked_irq()"), this
> patch replaces the open code implementation with a single macro call.
> 
> No functional change intended.
> 
> Signed-off-by: Wen Yang <wenyang.linux@...mail.com>
> Cc: Alexander Viro <viro@...iv.linux.org.uk>
> Cc: Christoph Hellwig <hch@....de>
> Cc: Dylan Yudaken <dylany@...com>
> Cc: Jens Axboe <axboe@...nel.dk>
> Cc: David Woodhouse <dwmw@...zon.co.uk>
> Cc: Fu Wei <wefu@...hat.com>
> Cc: Paolo Bonzini <pbonzini@...hat.com>
> Cc: Michal Nazarewicz <m.nazarewicz@...sung.com>
> Cc: Matthew Wilcox <willy@...radead.org>
> Cc: linux-fsdevel@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> ---
>  fs/eventfd.c | 41 +++++++----------------------------------
>  1 file changed, 7 insertions(+), 34 deletions(-)

Reviewed-by: Eric Biggers <ebiggers@...gle.com>

- Eric