linux-kernel - Re: [PATCH 4/4] Move USE_WCACHING to drivers/block/pktcdvd.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 17 Feb 2023 22:08:11 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Thomas Huth" <thuth@...hat.com>, linux-kernel@...r.kernel.org
Cc:     Linux-Arch <linux-arch@...r.kernel.org>,
        "Chas Williams" <3chas3@...il.com>,
        "Palmer Dabbelt" <palmer@...belt.com>, linux-block@...r.kernel.org,
        linux-fsdevel@...r.kernel.org,
        linux-atm-general@...ts.sourceforge.net,
        Netdev <netdev@...r.kernel.org>,
        "Andrew Waterman" <waterman@...s.berkeley.edu>,
        "Albert Ou" <aou@...s.berkeley.edu>
Subject: Re: [PATCH 4/4] Move USE_WCACHING to drivers/block/pktcdvd.c

On Fri, Feb 17, 2023, at 21:23, Thomas Huth wrote:
> From: Palmer Dabbelt <palmer@...belt.com>
>
> I don't think this was ever intended to be exposed to userspace, but
> it did require an "#ifdef CONFIG_*".  Since the name is kind of
> generic and was only used in one place, I've moved the definition to
> the one user.
>
> Signed-off-by: Palmer Dabbelt <palmer@...belt.com>
> Reviewed-by: Andrew Waterman <waterman@...s.berkeley.edu>
> Reviewed-by: Albert Ou <aou@...s.berkeley.edu>
> Message-Id: <1447119071-19392-11-git-send-email-palmer@...belt.com>
> Signed-off-by: Thomas Huth <thuth@...hat.com>
> ---
>  drivers/block/pktcdvd.c      | 11 +++++++++++
>  include/uapi/linux/pktcdvd.h | 11 -----------
>  2 files changed, 11 insertions(+), 11 deletions(-)

I'm fairly sure there are more bits in uapi/linux/pktcdvd.h that should
be in drivers/block/pktcdvd.c instead, along with all of
include/linux/pktcdvd.h, but this change is obvious and safe by itself,
so 

Reviewed-by: Arnd Bergmann <arnd@...db.de>