linux-kernel - RE: [PATCH v3 1/6] Update Kconfig and Makefile.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <02d4b4b5-4292-aef0-8e20-7ec031348e91@linux.ibm.com>
Date:   Fri, 17 Feb 2023 16:20:06 -0600
From:   Danny Tsen <dtsen@...ux.ibm.com>
To:     "Elliott, Robert (Servers)" <elliott@....com>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>
Cc:     "herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>,
        "leitao@...ian.org" <leitao@...ian.org>,
        "nayna@...ux.ibm.com" <nayna@...ux.ibm.com>,
        "appro@...ptogams.org" <appro@...ptogams.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "ltcgcw@...ux.vnet.ibm.com" <ltcgcw@...ux.vnet.ibm.com>,
        "dtsen@...ibm.com" <dtsen@...ibm.com>
Subject: RE: [PATCH v3 1/6] Update Kconfig and Makefile.

Hi Robert,

Power10+ means Power10 or later.  Other modes were not stripped by the 
perl script.

Thanks for the comments I will fix the suggestions.

-Danny

On 2/17/23 3:44 PM, Elliott, Robert (Servers) wrote:
>> +config CRYPTO_P10_AES_GCM
>> +	tristate "Stitched AES/GCM acceleration support on P10+ CPU (PPC)"
>> +	depends on PPC64 && POWER10_CPU && CPU_LITTLE_ENDIAN
>> +	select CRYPTO_LIB_AES
>> +	select CRYPTO_ALGAPI
>> +	select CRYPTO_AEAD
>> +	default m
>> +	help
>> +	  Support for cryptographic acceleration instructions on Power10+ CPU.
>> +	    This module supports stitched acceleration for AES/GCM in
>> hardware.
> Is "Power10+" a specific architecture or does that mean "Power10 or later"?
>
> Please follow the newer wording conventions for the menu item and
> help text, more like:
>
> config CRYPTO_AES_GCM_PPC_P10
>          tristate "AEAD cipher: AES in GCM mode (Power10)"
>
>          help
>            AEAD cipher: AES cipher algorithms (FIPS-197) with
> 	   GCM (Galois/Counter Mode) authenticated encryption mode (NIST SP800-38D)
>
>            Architecture: powerpc64 using:
>            - little-endian
>            - Power10 features
>
>            [some description here]
>
> Also, all the other powerpc cra_driver_names follow
> 	alg-arch
> not
> 	arch-alg
>
> so
> 	.base.cra_driver_name	= "p10_aes_gcm",
> might be better as
> 	.base.cra_driver_name	= "aes-gcm-p10",
>
> Patch 4 seems to have code for lots of other modes like CBC and XTS.
> Does the perl script strip out all of that?
>
>
>