linux-kernel - Re: [PATCH v8 12/13] dt-bindings: net: phy: Document support for leds node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 17 Feb 2023 17:10:20 -0600
From:   Rob Herring <robh@...nel.org>
To:     Christian Marangi <ansuelsmth@...il.com>
Cc:     Lee Jones <lee@...nel.org>, linux-leds@...r.kernel.org,
        Florian Fainelli <f.fainelli@...il.com>,
        devicetree@...r.kernel.org, John Crispin <john@...ozen.org>,
        Paolo Abeni <pabeni@...hat.com>, linux-kernel@...r.kernel.org,
        Russell King <linux@...linux.org.uk>,
        Bagas Sanjaya <bagasdotme@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Tim Harvey <tharvey@...eworks.com>,
        Alexander Stein <alexander.stein@...tq-group.com>,
        "David S. Miller" <davem@...emloft.net>,
        "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>,
        Jakub Kicinski <kuba@...nel.org>,
        Jonathan Corbet <corbet@....net>, linux-doc@...r.kernel.org,
        Rasmus Villemoes <rasmus.villemoes@...vas.dk>,
        netdev@...r.kernel.org, Pavel Machek <pavel@....cz>,
        Vladimir Oltean <olteanv@...il.com>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Andrew Lunn <andrew@...n.ch>, Arun.Ramadoss@...rochip.com
Subject: Re: [PATCH v8 12/13] dt-bindings: net: phy: Document support for
 leds node

On Thu, Feb 16, 2023 at 11:00:49AM +0100, Christian Marangi wrote:
> On Wed, Feb 15, 2023 at 08:32:11PM -0600, Rob Herring wrote:
> > 
> > On Thu, 16 Feb 2023 02:32:29 +0100, Christian Marangi wrote:
> > > Document support for leds node in phy and add an example for it.
> > > Phy led will have to match led-phy pattern and should be treated as a
> > > generic led.
> > > 
> > > Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
> > > ---
> > >  .../devicetree/bindings/net/ethernet-phy.yaml | 22 +++++++++++++++++++
> > >  1 file changed, 22 insertions(+)
> > > 
> > 
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> > 
> > yamllint warnings/errors:
> > 
> > dtschema/dtc warnings/errors:
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/ethernet-phy.example.dtb: ethernet-phy@0: leds:led-phy@0:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
> > 	'netdev' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
> > 	'netdev' does not match '^mmc[0-9]+$'
> > 	'netdev' does not match '^cpu[0-9]*$'
> > 	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/ethernet-phy.yaml
> > 
> 
> Hi, I could be wrong but this should be fixed by the previous patch that
> adds netdev to the trigger list.

If so, then it didn't apply for me which is what PW says. So what tree 
does this series apply too? linux-next? That's a tree no one can apply 
patches from.

Rob