linux-kernel - Re: [PATCH v1] scsi: ufs: core: Add trace event for MCQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <257dd9ff-26d3-72fb-729f-f0a04ff5f265@quicinc.com>
Date:   Fri, 17 Feb 2023 14:11:11 +0800
From:   Ziqi Chen <quic_ziqichen@...cinc.com>
To:     Bart Van Assche <bvanassche@....org>, <quic_asutoshd@...cinc.com>,
        <quic_cang@...cinc.com>, <mani@...nel.org>,
        <stanley.chu@...iatek.com>, <adrian.hunter@...el.com>,
        <beanhuo@...ron.com>, <avri.altman@....com>,
        <junwoo80.lee@...sung.com>, <martin.petersen@...cle.com>
CC:     <linux-scsi@...r.kernel.org>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        open list <linux-kernel@...r.kernel.org>,
        "open list:TRACING" <linux-trace-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] scsi: ufs: core: Add trace event for MCQ


On 2/17/2023 1:44 AM, Bart Van Assche wrote:
> On 2/15/23 18:45, Ziqi Chen wrote:
>> diff --git a/include/trace/events/ufs.h b/include/trace/events/ufs.h
>> index 599739e..a406404e 100644
>> --- a/include/trace/events/ufs.h
>> +++ b/include/trace/events/ufs.h
>> @@ -10,6 +10,7 @@
>>   #define _TRACE_UFS_H
>>     #include <linux/tracepoint.h>
>> +#include <ufs/ufshcd.h>
>
> Would including <ufs/ufs.h> here be sufficient?
Hi Bart.

The struct ufs_hw_queue which be used by this change not be defined in 
ufs.h.

Best Regards,

Ziqi

>
> Thanks,
>
> Bart.
>