linux-kernel - Re: [PATCH v4 5/5] LoongArch: Add support for kernel address space layout randomization (KASLR)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <41b6c7b779c1c4d33c644c406f337e27e124adaa.camel@xry111.site>
Date:   Fri, 17 Feb 2023 16:09:04 +0800
From:   Xi Ruoyao <xry111@...111.site>
To:     Youling Tang <tangyouling@...ngson.cn>,
        Huacai Chen <chenhuacai@...nel.org>,
        Jinyang He <hejinyang@...ngson.cn>
Cc:     Xuerui Wang <kernel@...0n.name>, loongarch@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 5/5] LoongArch: Add support for kernel address space
 layout randomization (KASLR)

On Fri, 2023-02-10 at 16:47 +0800, Youling Tang wrote:

> +               /* Sync the caches ready for execution of new kernel
> */
> +               __asm__ __volatile__ (
> +                       "ibar 0 \t\n"
> +                       "dbar 0 \t\n");

I think we should add ::: "memory" here to prevent a future compiler
from being too smart.

Otherwise LGTM.

-- 
Xi Ruoyao <xry111@...111.site>
School of Aerospace Science and Technology, Xidian University