linux-kernel - Re: [PATCH v3 1/1] KVM: s390: vsie: clarifications on setting the APCB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <faf9b6aa-a72b-3c61-c720-6b972792f720@linux.ibm.com>
Date:   Fri, 17 Feb 2023 09:21:15 +0100
From:   Pierre Morel <pmorel@...ux.ibm.com>
To:     David Hildenbrand <david@...hat.com>
Cc:     kvm@...r.kernel.org, linux-s390@...r.kernel.org,
        linux-kernel@...r.kernel.org, borntraeger@...ibm.com,
        frankja@...ux.ibm.com, cohuck@...hat.com, thuth@...hat.com,
        imbrenda@...ux.ibm.com, hca@...ux.ibm.com, gor@...ux.ibm.com,
        svens@...ux.ibm.com
Subject: Re: [PATCH v3 1/1] KVM: s390: vsie: clarifications on setting the
 APCB



On 2/16/23 14:04, David Hildenbrand wrote:
> On 14.02.23 13:28, Pierre Morel wrote:
>> The APCB is part of the CRYCB.
>> The calculation of the APCB origin can be done by adding
>> the APCB offset to the CRYCB origin.
>>
>> Current code makes confusing transformations, converting
>> the CRYCB origin to a pointer to calculate the APCB origin.
>>
>> Let's make things simpler and keep the CRYCB origin to make
>> these calculations.
>>
>> Signed-off-by: Pierre Morel <pmorel@...ux.ibm.com>
>> Reviewed-by: Claudio Imbrenda <imbrenda@...ux.ibm.com>
>> ---
> 
> Much better
> 
> Acked-by: David Hildenbrand <david@...hat.com>
> 

Thanks,
Pierre

-- 
Pierre Morel
IBM Lab Boeblingen