linux-kernel - Re: [PATCH] habanalabs: make some functions static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230217091309.GA2870547@linux.intel.com>
Date:   Fri, 17 Feb 2023 10:13:09 +0100
From:   Stanislaw Gruszka <stanislaw.gruszka@...ux.intel.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     ogabbay@...nel.org, Abaci Robot <abaci@...ux.alibaba.com>,
        osharabi@...ana.ai, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] habanalabs: make some functions static

On Fri, Feb 17, 2023 at 09:48:14AM +0100, Stanislaw Gruszka wrote:
> On Fri, Feb 17, 2023 at 02:26:26PM +0800, Jiapeng Chong wrote:
> > These functions are not used outside the file device.c, so the
> > modification is defined as static.
> > 
> > drivers/accel/habanalabs/common/device.c:2641:6: warning: no previous prototype for ‘hl_capture_fw_err’.
> > drivers/accel/habanalabs/common/device.c:2619:6: warning: no previous prototype for ‘hl_capture_hw_err’.
> > 
> > Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4098
> > Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
>
> Regards
> Stanislaw

Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka@...ux.intel.com>