| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <25fbbc7f-f137-c2c4-ddf8-d143fce1dcc5@intel.com>
Date: Thu, 16 Feb 2023 17:23:15 -0800
From: Fenghua Yu <fenghua.yu@...el.com>
To: Jacob Pan <jacob.jun.pan@...ux.intel.com>,
LKML <linux-kernel@...r.kernel.org>, <iommu@...ts.linux.dev>,
Jason Gunthorpe <jgg@...dia.com>,
Lu Baolu <baolu.lu@...ux.intel.com>,
Joerg Roedel <joro@...tes.org>,
Jean-Philippe Brucker <jean-philippe@...aro.com>
CC: Robin Murphy <robin.murphy@....com>, Will Deacon <will@...nel.org>,
"David Woodhouse" <dwmw2@...radead.org>,
Raj Ashok <ashok.raj@...el.com>,
"Tian, Kevin" <kevin.tian@...el.com>, Yi Liu <yi.l.liu@...el.com>,
Dave Hansen <dave.hansen@...el.com>,
Thomas Gleixner <tglx@...utronix.de>,
X86 Kernel <x86@...nel.org>, Dave Jiang <dave.jiang@...el.com>
Subject: Re: [PATCH v3 4/5] iommu/ioasid: Rename INVALID_IOASID
Hi, Jacob,
On 2/16/23 15:59, Jacob Pan wrote:
> INVALID_IOASID and IOMMU_PASID_INVALID are duplicated. Rename
> INVALID_IOASID and consolidate since we are moving away from IOASID
> infrastructure.
>
> Signed-off-by: Jacob Pan <jacob.jun.pan@...ux.intel.com>
> ---
> Documentation/x86/sva.rst | 2 +-
> arch/x86/kernel/traps.c | 5 ++++-
> drivers/dma/idxd/device.c | 8 ++++----
> drivers/dma/idxd/idxd.h | 1 +
> drivers/dma/idxd/init.c | 2 +-
> drivers/dma/idxd/irq.c | 2 +-
> drivers/iommu/intel/dmar.c | 4 ++--
> drivers/iommu/intel/iommu.c | 2 +-
> drivers/iommu/intel/svm.c | 2 +-
> drivers/iommu/iommu-sva.c | 2 +-
> include/linux/ioasid.h | 4 ----
> include/linux/iommu.h | 6 +++++-
> mm/init-mm.c | 4 ++--
> 13 files changed, 24 insertions(+), 20 deletions(-)
>
> diff --git a/Documentation/x86/sva.rst b/Documentation/x86/sva.rst
> index 2e9b8b0f9a0f..33cb05005982 100644
> --- a/Documentation/x86/sva.rst
> +++ b/Documentation/x86/sva.rst
> @@ -107,7 +107,7 @@ process share the same page tables, thus the same MSR value.
> PASID Life Cycle Management
> ===========================
>
> -PASID is initialized as INVALID_IOASID (-1) when a process is created.
> +PASID is initialized as IOMMU_PASID_INVALID (-1) when a process is created.
>
> Only processes that access SVA-capable devices need to have a PASID
> allocated. This allocation happens when a process opens/binds an SVA-capable
> diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c
> index d317dc3d06a3..d6fb03ebf548 100644
> --- a/arch/x86/kernel/traps.c
> +++ b/arch/x86/kernel/traps.c
> @@ -40,7 +40,10 @@
> #include <linux/io.h>
> #include <linux/hardirq.h>
> #include <linux/atomic.h>
> -#include <linux/ioasid.h>
> +
> +#ifdef CONFIG_IOMMU_SVA
> +#include <linux/iommu.h>
> +#endif
>
> #include <asm/stacktrace.h>
> #include <asm/processor.h>
> diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c
> index 29dbb0f52e18..125652a8bb29 100644
> --- a/drivers/dma/idxd/device.c
> +++ b/drivers/dma/idxd/device.c
> @@ -1194,7 +1194,7 @@ static void idxd_device_set_perm_entry(struct idxd_device *idxd,
> {
> union msix_perm mperm;
>
> - if (ie->pasid == INVALID_IOASID)
> + if (ie->pasid == IOMMU_PASID_INVALID)
> return;
>
> mperm.bits = 0;
> @@ -1224,7 +1224,7 @@ void idxd_wq_free_irq(struct idxd_wq *wq)
> idxd_device_clear_perm_entry(idxd, ie);
> ie->vector = -1;
> ie->int_handle = INVALID_INT_HANDLE;
> - ie->pasid = INVALID_IOASID;
> + ie->pasid = IOMMU_PASID_INVALID;
> }
>
> int idxd_wq_request_irq(struct idxd_wq *wq)
> @@ -1240,7 +1240,7 @@ int idxd_wq_request_irq(struct idxd_wq *wq)
>
> ie = &wq->ie;
> ie->vector = pci_irq_vector(pdev, ie->id);
> - ie->pasid = device_pasid_enabled(idxd) ? idxd->pasid : INVALID_IOASID;
> + ie->pasid = device_pasid_enabled(idxd) ? idxd->pasid : IOMMU_PASID_INVALID;
> idxd_device_set_perm_entry(idxd, ie);
>
> rc = request_threaded_irq(ie->vector, NULL, idxd_wq_thread, 0, "idxd-portal", ie);
> @@ -1265,7 +1265,7 @@ int idxd_wq_request_irq(struct idxd_wq *wq)
> free_irq(ie->vector, ie);
> err_irq:
> idxd_device_clear_perm_entry(idxd, ie);
> - ie->pasid = INVALID_IOASID;
> + ie->pasid = IOMMU_PASID_INVALID;
> return rc;
> }
>
> diff --git a/drivers/dma/idxd/idxd.h b/drivers/dma/idxd/idxd.h
> index 7ced8d283d98..417e602a46b6 100644
> --- a/drivers/dma/idxd/idxd.h
> +++ b/drivers/dma/idxd/idxd.h
> @@ -13,6 +13,7 @@
> #include <linux/ioasid.h>
> #include <linux/bitmap.h>
> #include <linux/perf_event.h>
> +#include <linux/iommu.h>
> #include <uapi/linux/idxd.h>
> #include "registers.h"
>
> diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c
> index 529ea09c9094..f30eef701970 100644
> --- a/drivers/dma/idxd/init.c
> +++ b/drivers/dma/idxd/init.c
> @@ -105,7 +105,7 @@ static int idxd_setup_interrupts(struct idxd_device *idxd)
> ie = idxd_get_ie(idxd, msix_idx);
> ie->id = msix_idx;
> ie->int_handle = INVALID_INT_HANDLE;
> - ie->pasid = INVALID_IOASID;
> + ie->pasid = IOMMU_PASID_INVALID;
>
> spin_lock_init(&ie->list_lock);
> init_llist_head(&ie->pending_llist);
> diff --git a/drivers/dma/idxd/irq.c b/drivers/dma/idxd/irq.c
> index aa314ebec587..242f1f0b9f09 100644
> --- a/drivers/dma/idxd/irq.c
> +++ b/drivers/dma/idxd/irq.c
> @@ -80,7 +80,7 @@ static void idxd_int_handle_revoke_drain(struct idxd_irq_entry *ie)
> desc.opcode = DSA_OPCODE_DRAIN;
> desc.priv = 1;
>
> - if (ie->pasid != INVALID_IOASID)
> + if (ie->pasid != IOMMU_PASID_INVALID)
It's better to change to:
+ if (pasid_valid(ie->paid))
If pasid_vaild() is called, any invalid PASID value change in the future
will be hidden in pasid_valid() and won't impact this code any more.
And checking pasid_valid() is more readable and meaninful than direct
checking the invalid PASID value.
> desc.pasid = ie->pasid;
> desc.int_handle = ie->int_handle;
> portal = idxd_wq_portal_addr(wq);
> diff --git a/drivers/iommu/intel/dmar.c b/drivers/iommu/intel/dmar.c
> index bf0bfe5ba7a7..c567f94b66c7 100644
> --- a/drivers/iommu/intel/dmar.c
> +++ b/drivers/iommu/intel/dmar.c
> @@ -1933,7 +1933,7 @@ static int dmar_fault_do_one(struct intel_iommu *iommu, int type,
> return 0;
> }
>
> - if (pasid == INVALID_IOASID)
> + if (pasid == IOMMU_PASID_INVALID)
Ditto.
> pr_err("[%s NO_PASID] Request device [%02x:%02x.%d] fault addr 0x%llx [fault reason 0x%02x] %s\n",
> type ? "DMA Read" : "DMA Write",
> source_id >> 8, PCI_SLOT(source_id & 0xFF),
> @@ -2014,7 +2014,7 @@ irqreturn_t dmar_fault(int irq, void *dev_id)
> if (!ratelimited)
> /* Using pasid -1 if pasid is not present */
> dmar_fault_do_one(iommu, type, fault_reason,
> - pasid_present ? pasid : INVALID_IOASID,
> + pasid_present ? pasid : IOMMU_PASID_INVALID,
> source_id, guest_addr);
>
> fault_index++;
> diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
> index a295e80fdfe8..10f657828d3a 100644
> --- a/drivers/iommu/intel/iommu.c
> +++ b/drivers/iommu/intel/iommu.c
> @@ -876,7 +876,7 @@ void dmar_fault_dump_ptes(struct intel_iommu *iommu, u16 source_id,
> return;
> }
> /* For request-without-pasid, get the pasid from context entry */
> - if (intel_iommu_sm && pasid == INVALID_IOASID)
> + if (intel_iommu_sm && pasid == IOMMU_PASID_INVALID)
Ditto.
> pasid = PASID_RID2PASID;
>
> dir_index = pasid >> PASID_PDE_SHIFT;
> diff --git a/drivers/iommu/intel/svm.c b/drivers/iommu/intel/svm.c
> index c76b66263467..be98af2fce06 100644
> --- a/drivers/iommu/intel/svm.c
> +++ b/drivers/iommu/intel/svm.c
> @@ -274,7 +274,7 @@ static int pasid_to_svm_sdev(struct device *dev, unsigned int pasid,
> if (WARN_ON(!mutex_is_locked(&pasid_mutex)))
> return -EINVAL;
>
> - if (pasid == INVALID_IOASID || pasid >= PASID_MAX)
> + if (pasid == IOMMU_PASID_INVALID || pasid >= PASID_MAX)
> return -EINVAL;
>
> svm = pasid_private_find(pasid);
> diff --git a/drivers/iommu/iommu-sva.c b/drivers/iommu/iommu-sva.c
> index 17821ad5bf9b..1f1b4d680ede 100644
> --- a/drivers/iommu/iommu-sva.c
> +++ b/drivers/iommu/iommu-sva.c
> @@ -41,7 +41,7 @@ static int iommu_sva_alloc_pasid(struct mm_struct *mm, ioasid_t min, ioasid_t ma
>
> void mm_pasid_init(struct mm_struct *mm)
> {
> - mm->pasid = INVALID_IOASID;
> + mm->pasid = IOMMU_PASID_INVALID;
> }
>
> /* Associate a PASID with an mm_struct: */
> diff --git a/include/linux/ioasid.h b/include/linux/ioasid.h
> index af1c9d62e642..9ef22552376c 100644
> --- a/include/linux/ioasid.h
> +++ b/include/linux/ioasid.h
> @@ -40,10 +40,6 @@ void *ioasid_find(struct ioasid_set *set, ioasid_t ioasid,
> int ioasid_register_allocator(struct ioasid_allocator_ops *allocator);
> void ioasid_unregister_allocator(struct ioasid_allocator_ops *allocator);
> int ioasid_set_data(ioasid_t ioasid, void *data);
> -static inline bool pasid_valid(ioasid_t ioasid)
> -{
> - return ioasid != INVALID_IOASID;
> -}
>
> #else /* !CONFIG_IOASID */
> static inline ioasid_t ioasid_alloc(struct ioasid_set *set, ioasid_t min,
> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> index 46e1347bfa22..f04d3f05784a 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -193,7 +193,11 @@ enum iommu_dev_features {
> };
>
> #define IOMMU_PASID_INVALID (-1U)
> -
> +typedef unsigned int ioasid_t;
> +static inline bool pasid_valid(ioasid_t ioasid)
> +{
> + return ioasid != IOMMU_PASID_INVALID;
> +}
> #ifdef CONFIG_IOMMU_API
>
> /**
> diff --git a/mm/init-mm.c b/mm/init-mm.c
> index c9327abb771c..a084039f55d8 100644
> --- a/mm/init-mm.c
> +++ b/mm/init-mm.c
> @@ -10,7 +10,7 @@
>
> #include <linux/atomic.h>
> #include <linux/user_namespace.h>
> -#include <linux/ioasid.h>
> +#include <linux/iommu.h>
> #include <asm/mmu.h>
>
> #ifndef INIT_MM_CONTEXT
> @@ -40,7 +40,7 @@ struct mm_struct init_mm = {
> .user_ns = &init_user_ns,
> .cpu_bitmap = CPU_BITS_NONE,
> #ifdef CONFIG_IOMMU_SVA
> - .pasid = INVALID_IOASID,
> + .pasid = IOMMU_PASID_INVALID,
> #endif
> INIT_MM_CONTEXT(init_mm)
> };
Thanks.
-Fenghua
Powered by blists - more mailing lists