linux-kernel - Re: [PATCH] serial: 8250_fintek: Add using BIOS IRQ default setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y+9GelDBcbtDQwHl@kroah.com>
Date:   Fri, 17 Feb 2023 10:18:50 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     "Ji-Ze Hong (Peter Hong)" <hpeter@...il.com>
Cc:     jirislaby@...nel.org, ilpo.jarvinen@...ux.intel.com,
        l.sanfilippo@...bus.com, andy.shevchenko@...il.com,
        peter_hong@...tek.com.tw, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        "Ji-Ze Hong (Peter Hong)" <hpeter+linux_kernel@...il.com>
Subject: Re: [PATCH] serial: 8250_fintek: Add using BIOS IRQ default setting

On Fri, Feb 17, 2023 at 04:49:53PM +0800, Ji-Ze Hong (Peter Hong) wrote:
> In 8250_fintek.c probe_setup_port(), we'll detect the IRQ trigger mode by
> irq_get_irq_data() and pass it to fintek_8250_set_irq_mode(). If detected
> Edge mode, we'll set the UART with Edge/High mode, otherwise Level/Low.
> 
> But in some motherboard, The APIC maybe setting to Level/High. In this case
> the driver will setting wrong configuration into UART. So we add a option
> to kernel parameter to control the driver as following:
> 
> 	fintek_uart_irq_mode_override= [SERIAL]
> 		{default, bios}
> 		If the parameter is "default", the driver will using
> 		former IRQ override methed(By IRQ trigger type).
> 		otherwise, we'll don't change the UART IRQ setting.
> 
> Signed-off-by: Ji-Ze Hong (Peter Hong) <hpeter+linux_kernel@...il.com>

Also note, your From: line does not match this line, so I couldn't take
this patch anyway :(

And why are you sending patches through a random gmail account and not
your fintek.com.tw address?  Please use that one, so that we can easily
verify that this is coming from the proper address and no one is
impersonating you.

thanks,

greg k-h