linux-kernel - Re: [Patch] [tegra] Remove unneeded version.h includes pointed out by 'make versioncheck'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <74818031-0a0f-bdcb-3a04-434203f7c99a@nvidia.com>
Date:   Fri, 17 Feb 2023 09:39:29 +0000
From:   Jon Hunter <jonathanh@...dia.com>
To:     Jesper Juhl <jesperjuhl76@...il.com>, linux-kernel@...r.kernel.org
Cc:     linux-tegra@...r.kernel.org,
        Thierry Reding <thierry.reding@...il.com>
Subject: Re: [Patch] [tegra] Remove unneeded version.h includes pointed out by
 'make versioncheck'


On 17/02/2023 09:30, Jon Hunter wrote:
> 
> On 16/02/2023 00:53, Jesper Juhl wrote:
>>  From 7264ec7d00ece4b56fe9fafa3237d4870cbe6785 Mon Sep 17 00:00:00 2001
>> From: Jesper Juhl <jesperjuhl76@...il.com>
>> Date: Mon, 13 Feb 2023 02:49:50 +0100
>> Subject: [PATCH 04/12] [tegra] Remove unneeded version.h includes 
>> pointed out
>>   by 'make versioncheck'
>>
>> Signed-off-by: Jesper Juhl <jesperjuhl76@...il.com>
> 
> 
> The patch looks correct, but there is no commit message and I am not 
> sure why the header is in the body of the message. Make sure you use git 
> send-email to send patches.

Also the patch $subject prefix should match subsystem you are patching.
You can check this by looking at the git history ...

$ git log --oneline drivers/soc/tegra/cbb/
b6c6bbfc65f5 soc/tegra: cbb: Remove redundant dev_err call
fa9b5246e260 soc/tegra: cbb: Use DEFINE_SHOW_ATTRIBUTE to simplify tegra_cbb_err
2927cf85f487 soc/tegra: cbb: Check firewall before enabling error reporting
55084947d6b4 soc/tegra: cbb: Add checks for potential out of bound errors

So you want some like "soc/tegra: cbb: Remove unneeded version.h header"

Jon

-- 
nvpublic