lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 17 Feb 2023 12:35:17 +1100 From: Michael Ellerman <mpe@...erman.id.au> To: Josh Poimboeuf <jpoimboe@...nel.org>, Stephen Rothwell <sfr@...b.auug.org.au>, Sathvika Vasireddy <sv@...ux.ibm.com>, Christophe Leroy <christophe.leroy@...roup.eu> Cc: Peter Zijlstra <peterz@...radead.org>, Linux Next Mailing List <linux-next@...r.kernel.org>, PowerPC <linuxppc-dev@...ts.ozlabs.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: linux-next: build warning after merge of the powerpc tree Josh Poimboeuf <jpoimboe@...nel.org> writes: > On Thu, Feb 16, 2023 at 02:40:31PM +1100, Stephen Rothwell wrote: >> Hi all, >> >> After merging the powerpc tree, today's linux-next build (powerpc >> pseries_le_defconfig) produced this warning: >> >> arch/powerpc/kernel/head_64.o: warning: objtool: .text+0x6128: unannotated intra-function call >> >> I have no idea what caused this. > > Adding Sathvika and Christophe. > > The short term fix would be something like the below, but... > > If powerpc objtool is only doing mcount, does it even make sense to run > objtool on asm files? If so, there are probably a lot more cleanups > needed for the asm code. I would like to enable more of the objtool checks eventually, although I don't have a timeline for that. But I'd prefer to keep checking the asm code seeing as we've already enabled that. > So I'm thinking either we should cleanup all the powerpc asm code with > annotations like below, or we should try to make objtool mcount-mode > ignore asm files. I think we have most of the code annotated already, this is a new warning because that code is newly refactored by a commit I applied. I'll have to fix my build scripts to error out on objtool warnings. cheers > diff --git a/arch/powerpc/kernel/head_64.S b/arch/powerpc/kernel/head_64.S > index 3a7266fa8a18..1febb56ebaeb 100644 > --- a/arch/powerpc/kernel/head_64.S > +++ b/arch/powerpc/kernel/head_64.S > @@ -472,7 +472,7 @@ SYM_FUNC_START_LOCAL(__mmu_off) > b . /* prevent speculative execution */ > SYM_FUNC_END(__mmu_off) > > -start_initialization_book3s: > +SYM_FUNC_START_LOCAL(start_initialization_book3s) > mflr r25 > > /* Setup some critical 970 SPRs before switching MMU off */ > @@ -494,6 +494,7 @@ start_initialization_book3s: > > mtlr r25 > blr > +SYM_FUNC_END(start_initialization_book3s) > #endif > > /*
Powered by blists - more mailing lists