linux-kernel - Re: [PATCH] gpio: sim: fix a memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=MfGCLFwzaV_pbHkrfRUCcM8E6zQtEAeXxEherdvcNo14A@mail.gmail.com>
Date:   Fri, 17 Feb 2023 12:05:19 +0100
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Kent Gibson <warthog618@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Viresh Kumar <viresh.kumar@...aro.org>
Cc:     linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Mirsad Goran Todorovac <mirsad.todorovac@....unizg.hr>
Subject: Re: [PATCH] gpio: sim: fix a memory leak

On Thu, Feb 16, 2023 at 3:16 PM Bartosz Golaszewski <brgl@...ev.pl> wrote:
>
> Fix an inverted logic bug in gpio_sim_remove_hogs() that leads to GPIO
> hog structures never being freed.
>
> Fixes: cb8c474e79be ("gpio: sim: new testing module")
> Reported-by: Mirsad Goran Todorovac <mirsad.todorovac@....unizg.hr>
> Signed-off-by: Bartosz Golaszewski <brgl@...ev.pl>
> ---
>  drivers/gpio/gpio-sim.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c
> index 60514bc5454f..9e3893b19e4f 100644
> --- a/drivers/gpio/gpio-sim.c
> +++ b/drivers/gpio/gpio-sim.c
> @@ -736,7 +736,7 @@ static void gpio_sim_remove_hogs(struct gpio_sim_device *dev)
>
>         gpiod_remove_hogs(dev->hogs);
>
> -       for (hog = dev->hogs; !hog->chip_label; hog++) {
> +       for (hog = dev->hogs; hog->chip_label; hog++) {
>                 kfree(hog->chip_label);
>                 kfree(hog->line_name);
>         }
> --
> 2.37.2
>

Applied and fixed the email address used.

Bart