linux-kernel - Re: [PATCH 2/2] pinctrl: at91: Remove pioc_index from struct at91_gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 17 Feb 2023 11:47:14 +0000
From:   <Claudiu.Beznea@...rochip.com>
To:     <broonie@...nel.org>, <Ludovic.Desroches@...rochip.com>,
        <linus.walleij@...aro.org>, <Nicolas.Ferre@...rochip.com>,
        <alexandre.belloni@...tlin.com>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-gpio@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] pinctrl: at91: Remove pioc_index from struct
 at91_gpio_chip

On 16.02.2023 17:43, Mark Brown wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> The pioc_idx member of struct at91_gpio_chip is write only, just remove it.
> 
> Signed-off-by: Mark Brown <broonie@...nel.org>

Reviewed-by: Claudiu Beznea <claudiu.beznea@...rochip.com>


> ---
>  drivers/pinctrl/pinctrl-at91.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
> index 8ecf52ec9b9b..a1db6ac9bd2e 100644
> --- a/drivers/pinctrl/pinctrl-at91.c
> +++ b/drivers/pinctrl/pinctrl-at91.c
> @@ -41,7 +41,6 @@ struct at91_pinctrl_mux_ops;
>   * @next: bank sharing same clock
>   * @pioc_hwirq: PIO bank interrupt identifier on AIC
>   * @pioc_virq: PIO bank Linux virtual interrupt
> - * @pioc_idx: PIO bank index
>   * @regbase: PIO bank virtual address
>   * @clock: associated clock
>   * @ops: at91 pinctrl mux ops
> @@ -55,7 +54,6 @@ struct at91_gpio_chip {
>         struct at91_gpio_chip   *next;
>         int                     pioc_hwirq;
>         int                     pioc_virq;
> -       int                     pioc_idx;
>         void __iomem            *regbase;
>         struct clk              *clock;
>         const struct at91_pinctrl_mux_ops *ops;
> @@ -1867,7 +1865,6 @@ static int at91_gpio_probe(struct platform_device *pdev)
>         at91_chip->ops = (const struct at91_pinctrl_mux_ops *)
>                 of_match_device(at91_gpio_of_match, &pdev->dev)->data;
>         at91_chip->pioc_virq = irq;
> -       at91_chip->pioc_idx = alias_idx;
> 
>         at91_chip->clock = devm_clk_get(&pdev->dev, NULL);
>         if (IS_ERR(at91_chip->clock)) {
> 
> --
> 2.34.1
>