linux-kernel - Re: [PATCH bpf-next] selftests/bpf: Remove not used headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a07641f4-5d92-94c0-9ca6-963c27869fc8@iogearbox.net>
Date:   Fri, 17 Feb 2023 17:36:04 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Stanislav Fomichev <sdf@...gle.com>,
        Tiezhu Yang <yangtiezhu@...ngson.cn>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Andrii Nakryiko <andrii@...nel.org>, bpf@...r.kernel.org,
        acme@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH bpf-next] selftests/bpf: Remove not used headers

On 2/16/23 7:31 PM, Stanislav Fomichev wrote:
> On 02/16, Tiezhu Yang wrote:
>> The following three uapi headers:
> 
>>      tools/arch/arm64/include/uapi/asm/bpf_perf_event.h
>>      tools/arch/s390/include/uapi/asm/bpf_perf_event.h
>>      tools/arch/s390/include/uapi/asm/ptrace.h
> 
>> were introduced in commit 618e165b2a8e ("selftests/bpf: sync kernel headers
>> and introduce arch support in Makefile"), they are not used any more after
>> commit 720f228e8d31 ("bpf: fix broken BPF selftest build"), so remove them.
> 
> Let's maybe CC Arnaldo to make sure it doesn't affect perf? BPF build
> bots are happy it seems.
> 
>> Signed-off-by: Tiezhu Yang <yangtiezhu@...ngson.cn>
>> ---
>>   tools/arch/arm64/include/uapi/asm/bpf_perf_event.h |   9 -
>>   tools/arch/s390/include/uapi/asm/bpf_perf_event.h  |   9 -
>>   tools/arch/s390/include/uapi/asm/ptrace.h          | 458 ---------------------
>>   3 files changed, 476 deletions(-)
>>   delete mode 100644 tools/arch/arm64/include/uapi/asm/bpf_perf_event.h
>>   delete mode 100644 tools/arch/s390/include/uapi/asm/bpf_perf_event.h
>>   delete mode 100644 tools/arch/s390/include/uapi/asm/ptrace.h

Lgtm, I think test_verifier.c was the only user via ...

   - include/uapi/linux/bpf_perf_event.h
     -> include/uapi/asm/bpf_perf_event.h
        -> arch/*/include/uapi/asm/bpf_perf_event.h

... but we're actually pulling in the arch includes instead of the tooling
arch include. So these look indeed unused.