linux-kernel - Re: [PATCH v2 net-next 1/5] net: dsa: microchip: add rmon grouping for ethtool statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y++79sDREoyj+mWc@lunn.ch>
Date:   Fri, 17 Feb 2023 18:40:06 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     Rakesh Sankaranarayanan <rakesh.sankaranarayanan@...rochip.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        woojung.huh@...rochip.com, UNGLinuxDriver@...rochip.com,
        f.fainelli@...il.com, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com,
        Thangaraj Samynathan <Thangaraj.S@...rochip.com>
Subject: Re: [PATCH v2 net-next 1/5] net: dsa: microchip: add rmon grouping
 for ethtool statistics

On Fri, Feb 17, 2023 at 06:53:46PM +0200, Vladimir Oltean wrote:
> On Fri, Feb 17, 2023 at 04:32:07PM +0530, Rakesh Sankaranarayanan wrote:
> >     Add support for ethtool standard device statistics grouping. Support rmon
> >     statistics grouping using rmon groups parameter in ethtool command. rmon
> >     provides packet size based range grouping. Common mib parameters are used
> >     across all KSZ series swtches for packet size statistics, except for
> >     KSZ8830. KSZ series have mib counters for packets with size:
> >     - less than 64 Bytes,
> >     - 65 to 127 Bytes,
> >     - 128 to 255 Bytes,
> >     - 256 to 511 Bytes,
> >     - 512 to 1023 Bytes,
> >     - 1024 to 1522 Bytes,
> >     - 1523 to 2000 Bytes and
> >     - More than 2001 Bytes
> >     KSZ8830 have mib counters upto 1024-1522 range only. Since no other change,
> >     common range used across all KSZ series, but used upto only upto 1024-1522
> >     for KSZ8830.
> 
> Why are all commit messages indented in this way? Please keep the
> default text indentation at 0 characters. I have never seen this style
> in "git log".

I can make a guess

git show HEAD

notice how the commit message is indented. So if you where to
cut/paste that, you get the extra indent. It is better to do:

git commit -C 8e757b50555f3ae ; git commit --am

to copy a commit message from 8e757b50555f3ae, and then edit it to
suite.

	Andrew