linux-kernel - Re: [PATCH net-next] net: phy: micrel: Add support for PTP_PF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230218121039.4kgejvhbi4ppkij6@soft-dev3-1>
Date:   Sat, 18 Feb 2023 13:10:39 +0100
From:   Horatiu Vultur <horatiu.vultur@...rochip.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <hkallweit1@...il.com>, <linux@...linux.org.uk>,
        <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
        <pabeni@...hat.com>, <richardcochran@...il.com>
Subject: Re: [PATCH net-next] net: phy: micrel: Add support for PTP_PF_PEROUT
 for lan8841

The 02/18/2023 01:55, Andrew Lunn wrote:
> 
> > +static void lan8841_ptp_update_target(struct kszphy_ptp_priv *ptp_priv,
> > +                                   const struct timespec64 *ts);
> > +
> 
> Please avoid this. Move the code around so everything is in
> order. Generally, i do such moves in an initial patch which only moves
> code, making it easy to review.

Thanks for the suggestion. I will update this in the next version.

> 
>       Andrew

-- 
/Horatiu