linux-kernel - Re: [PATCH] first patch test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y/DJ+iOnJUVQSdSn@pendragon.ideasonboard.com>
Date:   Sat, 18 Feb 2023 14:52:10 +0200
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Bagas Sanjaya <bagasdotme@...il.com>
Cc:     Vishal Parmar <vishistriker@...il.com>, mchehab@...nel.org,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] first patch test

On Sat, Feb 18, 2023 at 04:41:27PM +0700, Bagas Sanjaya wrote:
> On Sat, Feb 18, 2023 at 08:42:37AM +0530, Vishal Parmar wrote:
> > Signed-off-by: Vishal Parmar <vishistriker@...il.com>
> > ---
> >  drivers/media/usb/uvc/uvc_driver.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> > index e4bcb5011360..c79dcee2213f 100644
> > --- a/drivers/media/usb/uvc/uvc_driver.c
> > +++ b/drivers/media/usb/uvc/uvc_driver.c
> > @@ -2082,7 +2082,7 @@ static int uvc_probe(struct usb_interface *intf,
> >  		(const struct uvc_device_info *)id->driver_info;
> >  	int function;
> >  	int ret;
> > -
> > +        pr_info("I changed uvcvideo driver in the Linux Kernel\n");
> >  	/* Allocate memory for the device and initialize it. */
> >  	dev = kzalloc(sizeof(*dev), GFP_KERNEL);
> >  	if (dev == NULL)
> 
> Hi and welcome to LKML!
> 
> As others has pointed, it seems like you had sent a patch which only
> added noises to the ML. Also, I see that you send the similar change as
> one in "Modifying a driver under the VM" section of kernelnewbies.org
> [1].

Vishal, could you please point us to the exact location of the
instructions you've interpreted as telling you to send this patch out ?
I'd like to get that fixed to avoid similar noise in the future.

> If you'd like to submit patches, you can do so by contributing to
> drivers/staging/ drivers first or documentation files at Documentation/.
> It is not recommended to go outside of there until you've gained
> experience and have several of your patches accepted and applied by
> respective maintainers.
> 
> In any case, please read Documentation/process/submitting-patches.rst.
> 
> Thanks.
> 
> [1]: https://kernelnewbies.org/FirstKernelPatch

-- 
Regards,

Laurent Pinchart