[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e965c234-517f-007d-6839-a6afa5f054ad@omp.ru>
Date: Sat, 18 Feb 2023 19:16:03 +0300
From: Sergey Shtylyov <s.shtylyov@....ru>
To: Ondrej Zary <linux@...y.sk>,
Damien Le Moal <damien.lemoal@...nsource.wdc.com>
CC: Christoph Hellwig <hch@....de>, Jens Axboe <axboe@...nel.dk>,
Tim Waugh <tim@...erelk.net>, <linux-block@...r.kernel.org>,
<linux-parport@...ts.infradead.org>, <linux-ide@...r.kernel.org>,
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 06/18] pata_parport: remove devtype from struct pi_adapter
On 2/15/23 10:45 PM, Ondrej Zary wrote:
> Only bpck driver uses devtype but it never gets set in pata_parport.
> Remove it.
> As most bpck devices are CD-ROMs, always run the code that depends
> on devtype == PI_PCD.
>
> Signed-off-by: Ondrej Zary <linux@...y.sk>
Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>
[...]
> diff --git a/drivers/ata/pata_parport/bpck.c b/drivers/ata/pata_parport/bpck.c
> index b9174cf8863c..96386a10c22f 100644
> --- a/drivers/ata/pata_parport/bpck.c
> +++ b/drivers/ata/pata_parport/bpck.c
> @@ -241,14 +241,14 @@ static void bpck_connect ( PIA *pi )
>
> WR(5,8);
>
> - if (pi->devtype == PI_PCD) {
> +/* if (pi->devtype == PI_PCD) { possibly wrong, purpose unknown */
> WR(0x46,0x10); /* fiddle with ESS logic ??? */
> WR(0x4c,0x38);
> WR(0x4d,0x88);
> WR(0x46,0xa0);
> WR(0x41,0);
> WR(0x4e,8);
> - }
> +/* }*/
You could have used // here, scripts/checkpatch.pl has nothing against it now...
[...]
MBR, Sergey
Powered by blists - more mailing lists