linux-kernel - Re: [PATCH 12/18] pata_parport: use print_hex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e16f8ecd-85f2-dca7-68ef-53958719e943@omp.ru>
Date:   Sat, 18 Feb 2023 20:04:42 +0300
From:   Sergey Shtylyov <s.shtylyov@....ru>
To:     Ondrej Zary <linux@...y.sk>,
        Damien Le Moal <damien.lemoal@...nsource.wdc.com>
CC:     Christoph Hellwig <hch@....de>, Jens Axboe <axboe@...nel.dk>,
        Tim Waugh <tim@...erelk.net>, <linux-block@...r.kernel.org>,
        <linux-parport@...ts.infradead.org>, <linux-ide@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 12/18] pata_parport: use print_hex_*

On 2/15/23 10:45 PM, Ondrej Zary wrote:

> Use print_hex_* for debug dumps.
> 
> Signed-off-by: Ondrej Zary <linux@...y.sk>

[...]
> diff --git a/drivers/ata/pata_parport/epat.c b/drivers/ata/pata_parport/epat.c
> index 389faa6ae49d..b08ed2f86668 100644
> --- a/drivers/ata/pata_parport/epat.c
> +++ b/drivers/ata/pata_parport/epat.c
> @@ -280,7 +280,7 @@ static int epat_test_proto(struct pi_adapter *pi, char *scratch, int verbose)
>          epat_disconnect(pi);
>  
>  	dev_dbg(&pi->dev, "epat: port 0x%x, mode %d, ccr %x, test=(%d,%d,%d)\n",
> -	       pi->port, pi->mode, cc, e[0], e[1], f);
> +		pi->port, pi->mode, cc, e[0], e[1], f);

   Mhm, this (and below changes) belongs to patch #11... :-/

[...]

MBR, Sergey