linux-kernel - Re: [PATCH] Staging: r8188eu: Fixed block comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5de7b776-4fbe-f6f8-ffa9-fdef337c9c20@gmail.com>
Date:   Sat, 18 Feb 2023 20:11:01 +0100
From:   Philipp Hortmann <philipp.g.hortmann@...il.com>
To:     Khadija Kamran <kamrankhadijadj@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Cc:     Larry.Finger@...inger.net, phil@...lpotter.co.uk,
        paskripkin@...il.com, gregkh@...uxfoundation.org
Subject: Re: [PATCH] Staging: r8188eu: Fixed block comment

On 2/17/23 08:17, Khadija Kamran wrote:
> Fixed block comment by adding '*' in each line. The Check message was
> shown by using checkpatch.pl script.
> 
> Signed-off-by: Khadija Kamran <kamrankhadijadj@...il.com>
> ---
>   drivers/staging/r8188eu/core/rtw_br_ext.c | 19 ++++++++++---------
>   1 file changed, 10 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/core/rtw_br_ext.c b/drivers/staging/r8188eu/core/rtw_br_ext.c
> index a7c67014dde0..03025dc89533 100644
> --- a/drivers/staging/r8188eu/core/rtw_br_ext.c
> +++ b/drivers/staging/r8188eu/core/rtw_br_ext.c
> @@ -36,15 +36,16 @@
>   #define WAIT_TIME_PPPOE	5	/*  waiting time for pppoe server in sec */
>   
>   /*-----------------------------------------------------------------
> -  How database records network address:
> -	   0    1    2    3    4    5    6    7    8    9   10
> -	|----|----|----|----|----|----|----|----|----|----|----|
> -  IPv4  |type|                             |      IP addr      |
> -  IPX   |type|      Net addr     |          Node addr          |
> -  IPX   |type|      Net addr     |Sckt addr|
> -  Apple |type| Network |node|
> -  PPPoE |type|   SID   |           AC MAC            |
> ------------------------------------------------------------------*/
> + * How database records network address:
> + *	    0    1    2    3    4    5    6    7    8    9   10
> + *	 |----|----|----|----|----|----|----|----|----|----|----|
> + * IPv4  |type|                             |      IP addr      |
> + * IPX   |type|      Net addr     |          Node addr          |
> + * IPX   |type|      Net addr     |Sckt addr|
> + * Apple |type| Network |node|
> + * PPPoE |type|   SID   |           AC MAC            |
> + * ----------------------------------------------------------------
> + */
>   
>   /* Find a tag in pppoe frame and return the pointer */
>   static unsigned char *__nat25_find_pppoe_tag(struct pppoe_hdr *ph, unsigned short type)

Reviewed-by: Philipp Hortmann <philipp.g.hortmann@...il.com>