linux-kernel - Re: [PATCH v3] nvmem: u-boot-env: align endianness of crc32 values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 19 Feb 2023 13:30:42 +0100
From:   Christian Lamparter <chunkeey@...il.com>
To:     INAGAKI Hiroshi <musashino.open@...il.com>,
        Rafał Miłecki <rafal@...ecki.pl>
Cc:     srinivas.kandagatla@...aro.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] nvmem: u-boot-env: align endianness of crc32 values

Hi Hiroshi,
On 2/19/23 05:45,  Hiroshi wrote:
> On 2023/02/18 2:30, Christian Lamparter wrote:
>> On 2/13/23 14:37, Rafał Miłecki wrote:
>>> On 2023-02-13 14:23, INAGAKI Hiroshi wrote:
>>>> This patch fixes crc32 error on Big-Endianness system by conversion of
>>>> calculated crc32 value.
>>>>
>>>> Little-Endianness system:
>>>>
>>>>   obtained crc32: Little
>>>> calculated crc32: Little
>>>>
>>>> Big-Endianness system:
>>>>
>>>>   obtained crc32: Little
>>>> calculated crc32: Big
>>>>
>>>> log (APRESIA ApresiaLightGS120GT-SS, RTL8382M, Big-Endianness):
>>>>
>>>> [    8.570000] u_boot_env
>>>> 18001200.spi:flash@0:partitions:partition@...00: Invalid calculated
>>>> CRC32: 0x88cd6f09 (expected: 0x096fcd88)
>>>> [    8.580000] u_boot_env: probe of
>>>> 18001200.spi:flash@0:partitions:partition@...00 failed with error -22
>>>>
>>>> Fixes: f955dc144506 ("nvmem: add driver handling U-Boot environment variables")
>>>>
>>>> Signed-off-by: INAGAKI Hiroshi <musashino.open@...il.com>
>>>> ---
>> Hmm, this is strange. The kernel's u-boot-env driver works without any
>> additional changes in the le<->be department on the Big-Endian
>> PowerPC APM82181 WD MyBook Live NAS.
>>
>> Is there something odd going on with the WD MyBook Live, or is it
>> the APRESIA ApresiaLightGS120GT-SS that is special?
>>
> 
> This additional changes are for resolving sparse warnings. Of course it's 
> working fine on my device with the previous changes, but due to the warning
> it wasn't merged into the mainline and needs to be resolved.

Oh, yes. This could be why! I was wondering why any additional endian related
changes would be necessary. But no, they are not. This is the patch from
October/November last year.

I now remember '[Patch v2] nvmem: u-boot-env: align endianness of crc32 values' too
<https://lore.kernel.org/lkml/e7ebabf9-a7b2-6155-cdd0-5dafb6bb2a7a@isd.uni-stuttgart.de/T/>
and back then I provided a tested-by tag as well. So there's no difference between
the  APRESIA ApresiaLightGS120GT-SS and WD MyBook Live. Both will need this patch.

Cheers,
Christian