linux-kernel - Re: [PATCH 11/24] kbuild, soc: apple: apple-pmgr-pwrstate: remove MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <0f49c43d-c6e0-47a9-871b-6fbe4daaa37e@app.fastmail.com>
Date:   Sun, 19 Feb 2023 13:38:54 +0100
From:   "Sven Peter" <sven@...npeter.dev>
To:     "Nick Alcock" <nick.alcock@...cle.com>, mcgrof@...nel.org
Cc:     linux-modules@...r.kernel.org, linux-kernel@...r.kernel.org,
        "Hitomi Hasegawa" <hasegawa-hitomi@...itsu.com>,
        "Hector Martin" <marcan@...can.st>,
        "Philipp Zabel" <p.zabel@...gutronix.de>, asahi@...ts.linux.dev,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 11/24] kbuild, soc: apple: apple-pmgr-pwrstate: remove
 MODULE_LICENSE in non-modules

On Fri, Feb 17, 2023, at 15:10, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>
> Signed-off-by: Nick Alcock <nick.alcock@...cle.com>
> Suggested-by: Luis Chamberlain <mcgrof@...nel.org>
> Cc: Luis Chamberlain <mcgrof@...nel.org>
> Cc: linux-modules@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Cc: Hitomi Hasegawa <hasegawa-hitomi@...itsu.com>
> Cc: Hector Martin <marcan@...can.st>
> Cc: Sven Peter <sven@...npeter.dev>
> Cc: Philipp Zabel <p.zabel@...gutronix.de>
> Cc: asahi@...ts.linux.dev
> Cc: linux-arm-kernel@...ts.infradead.org
> ---

Acked-by: Sven Peter <sven@...npeter.dev>


Sven


>  drivers/soc/apple/apple-pmgr-pwrstate.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/soc/apple/apple-pmgr-pwrstate.c 
> b/drivers/soc/apple/apple-pmgr-pwrstate.c
> index e1122288409a..2c15474c7b53 100644
> --- a/drivers/soc/apple/apple-pmgr-pwrstate.c
> +++ b/drivers/soc/apple/apple-pmgr-pwrstate.c
> @@ -319,6 +319,5 @@ static struct platform_driver apple_pmgr_ps_driver 
> = {
> 
>  MODULE_AUTHOR("Hector Martin <marcan@...can.st>");
>  MODULE_DESCRIPTION("PMGR power state driver for Apple SoCs");
> -MODULE_LICENSE("GPL v2");
> 
>  module_platform_driver(apple_pmgr_ps_driver);
> -- 
> 2.39.1.268.g9de2f9a303