linux-kernel - Re: [PATCH 3/5] i2c: Add support for Intel LJCA USB I2C driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202302200748.p6HZohuJ-lkp@intel.com>
Date:   Mon, 20 Feb 2023 07:56:30 +0800
From:   kernel test robot <lkp@...el.com>
To:     Ye Xiang <xiang.ye@...el.com>, Lee Jones <lee@...nel.org>,
        Wolfram Sang <wsa-dev@...g-engineering.com>,
        Tyrone Ting <kfting@...oton.com>,
        Mark Brown <broonie@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-spi@...r.kernel.org,
        linux-gpio@...r.kernel.org
Cc:     oe-kbuild-all@...ts.linux.dev, srinivas.pandruvada@...el.com,
        heikki.krogerus@...ux.intel.com, andriy.shevchenko@...ux.intel.com,
        sakari.ailus@...ux.intel.com, zhifeng.wang@...el.com,
        wentong.wu@...el.com, lixu.zhang@...el.com,
        Ye Xiang <xiang.ye@...el.com>
Subject: Re: [PATCH 3/5] i2c: Add support for Intel LJCA USB I2C driver

Hi Ye,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on lee-mfd/for-mfd-next]
[also build test WARNING on lee-mfd/for-mfd-fixes wsa/i2c/for-next broonie-spi/for-next linus/master v6.2-rc8]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Ye-Xiang/mfd-Add-support-for-Intel-LJCA-device/20230220-023253
base:   https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
patch link:    https://lore.kernel.org/r/20230219183059.1029525-4-xiang.ye%40intel.com
patch subject: [PATCH 3/5] i2c: Add support for Intel LJCA USB I2C driver
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20230220/202302200748.p6HZohuJ-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/9faeca641d7d776bbd8158b606a77830eddde590
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Ye-Xiang/mfd-Add-support-for-Intel-LJCA-device/20230220-023253
        git checkout 9faeca641d7d776bbd8158b606a77830eddde590
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 olddefconfig
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/i2c/busses/ drivers/spi/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202302200748.p6HZohuJ-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/i2c/busses/i2c-ljca.c:339:40: warning: 'ljca_i2c_id' defined but not used [-Wunused-const-variable=]
     339 | static const struct platform_device_id ljca_i2c_id[] = {
         |                                        ^~~~~~~~~~~


vim +/ljca_i2c_id +339 drivers/i2c/busses/i2c-ljca.c

   337	
   338	#define LJCA_I2C_DRV_NAME "ljca-i2c"
 > 339	static const struct platform_device_id ljca_i2c_id[] = {
   340		{ LJCA_I2C_DRV_NAME, 0 },
   341		{ /* sentinel */ }
   342	};
   343	MODULE_DEVICE_TABLE(platform, ljca_i2c_id);
   344	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests