linux-kernel - Re: [PATCH v2] ext4: Fix function prototype mismatch for ext4_feat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <167678522170.2723470.13730761644590168004.b4-ty@mit.edu>
Date:   Sun, 19 Feb 2023 00:40:47 -0500
From:   "Theodore Ts'o" <tytso@....edu>
To:     Kees Cook <keescook@...omium.org>
Cc:     "Theodore Ts'o" <tytso@....edu>, linux-ext4@...r.kernel.org,
        llvm@...ts.linux.dev, Tom Rix <trix@...hat.com>,
        linux-hardening@...r.kernel.org,
        Nathan Chancellor <nathan@...nel.org>,
        Eric Biggers <ebiggers@...nel.org>, stable@...r.kernel.org,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Andreas Dilger <adilger.kernel@...ger.ca>,
        Riccardo Schirone <sirmy15@...il.com>,
        linux-kernel@...r.kernel.org,
        "Gustavo A . R . Silva" <gustavoars@...nel.org>
Subject: Re: [PATCH v2] ext4: Fix function prototype mismatch for ext4_feat_ktype

On Wed, 4 Jan 2023 13:09:12 -0800, Kees Cook wrote:
> With clang's kernel control flow integrity (kCFI, CONFIG_CFI_CLANG),
> indirect call targets are validated against the expected function
> pointer prototype to make sure the call target is valid to help mitigate
> ROP attacks. If they are not identical, there is a failure at run time,
> which manifests as either a kernel panic or thread getting killed.
> 
> ext4_feat_ktype was setting the "release" handler to "kfree", which
> doesn't have a matching function prototype. Add a simple wrapper
> with the correct prototype.
> 
> [...]

Applied, thanks!

[1/1] ext4: Fix function prototype mismatch for ext4_feat_ktype
      commit: d99a55a94a0db8eda4a336a6f21730b844b8d2d2

Best regards,
-- 
Theodore Ts'o <tytso@....edu>