linux-kernel - Re: amba pl011 non amba/sbsa driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y/HOvIMTE5XZaelm@kroah.com>
Date:   Sun, 19 Feb 2023 08:24:44 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Ramon Fried <rfried.dev@...il.com>
Cc:     linux@...linux.org.uk, jirislaby@...nel.org,
        linux-serial@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        Baruch Siach <baruch@...s.co.il>
Subject: Re: amba pl011 non amba/sbsa driver

On Sat, Feb 18, 2023 at 09:56:39PM +0200, Ramon Fried wrote:
> Hi.
> Our upcoming SOC is using pl011 ip, but we have a different NOC than
> AMBA and we don't want to use the SBSA, as it provides limited
> functionality in the UART.
> 
> My question is should we develop a new driver or add more
> functionality to the current driver.
> The pl011 driver is a bit messy, and the functionality we actually
> need is actually supported in the current driver, but I can't
> differentiate my HW using AMBA id.

If it's the same IP block, please use the same driver.  That way it will
be easier to maintain over the long-term.

thanks,

greg k-h