linux-kernel - Re: [PATCH v9 0/8] Parallel CPU bringup for x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Feb 2023 20:31:16 +0000
From:   David Woodhouse <dwmw2@...radead.org>
To:     Oleksandr Natalenko <oleksandr@...alenko.name>, tglx@...utronix.de,
        kim.phillips@....com, Usama Arif <usama.arif@...edance.com>
Cc:     arjan@...ux.intel.com, mingo@...hat.com, bp@...en8.de,
        dave.hansen@...ux.intel.com, hpa@...or.com, x86@...nel.org,
        pbonzini@...hat.com, paulmck@...nel.org,
        linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        rcu@...r.kernel.org, mimoja@...oja.de, hewenliang4@...wei.com,
        thomas.lendacky@....com, seanjc@...gle.com, pmenzel@...gen.mpg.de,
        fam.zheng@...edance.com, punit.agrawal@...edance.com,
        simon.evans@...edance.com, liangma@...ngbit.com
Subject: Re: [PATCH v9 0/8] Parallel CPU bringup for x86_64

On Mon, 2023-02-20 at 17:40 +0100, Oleksandr Natalenko wrote:
> Hello.
> 
> Thank you for your reply.
> 
> On pondělí 20. února 2023 17:20:13 CET David Woodhouse wrote:
> > On Mon, 2023-02-20 at 17:08 +0100, Oleksandr Natalenko wrote:
> > > 
> > > I've applied this to the v6.2 kernel, and suspend/resume broke on
> > > my
> > > Ryzen 5950X desktop. The machine suspends just fine, but on
> > > resume
> > > the screen stays blank, and there's no visible disk I/O.
> > > 
> > > Reverting the series brings suspend/resume back to working state.
> > 
> > Hm, thanks. What if you add 'no_parallel_bringup' on the command
> > line?
> 
> If the `no_parallel_bringup` param is added, the suspend/resume
> works.

Thanks for the testing. Can I ask you to do one further test: apply the
series only as far as patch 6/8 'x86/smpboot: Support parallel startup
of secondary CPUs'.

That will do the new startup asm sequence where each CPU finds its own
per-cpu data so it *could* work in parallel, but doesn't actually do
the bringup in parallel yet.

Does your box have a proper serial port? 

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5965 bytes)