linux-kernel - Re: [PATCH] scsi: ufs: Add select to CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230220093210.GA27366@thinkpad>
Date:   Mon, 20 Feb 2023 15:02:10 +0530
From:   Manivannan Sadhasivam <mani@...nel.org>
To:     Stephen Zhang <starzhangzsd@...il.com>
Cc:     jejb@...ux.ibm.com, artin.petersen@...cle.com,
        matthias.bgg@...il.com, angelogioacchino.delregno@...labora.com,
        beanhuo@...ron.com, bvanassche@....org, avri.altman@....com,
        yoshihiro.shimoda.uh@...esas.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, zhangshida@...inos.cn,
        k2ci <kernel-bot@...inos.cn>
Subject: Re: [PATCH] scsi: ufs: Add select to CONFIG_PM in Kconfig

On Mon, Feb 20, 2023 at 04:32:56PM +0800, Stephen Zhang wrote:
> From: Shida Zhang <zhangshida@...inos.cn>
> 
> From: Shida Zhang <zhangshida@...inos.cn>
> 
> In a configuration with CONFIG_SCSI_UFS_MEDIATEK set to 'm' and
> CONFIG_PM set to 'n', errors occur at compile time:
> 
> ====
> ../drivers/ufs/host/ufs-mediatek.c: In function ‘ufs_mtk_runtime_suspend’:
> ../drivers/ufs/host/ufs-mediatek.c:1621:8: error: implicit declaration of function ‘ufshcd_runtime_suspend’; did you mean ‘ufs_mtk_runtime_suspend’? [-Werror=implicit-function-declaration]
> ../drivers/ufs/host/ufs-mediatek.c: In function ‘ufs_mtk_runtime_resume’:
> ../drivers/ufs/host/ufs-mediatek.c:1636:9: error: implicit declaration of function ‘ufshcd_runtime_resume’; did you mean ‘ufs_mtk_runtime_resume’? [-Werror=implicit-function-declaration]
> ====
> 
> This patch fixes these by selecting CONFIG_PM from CONFIG_SCSI_UFS_MEDIATEK.
> 
> Reported-by: k2ci <kernel-bot@...inos.cn>
> Signed-off-by: Shida Zhang <zhangshida@...inos.cn>
> ---
>  drivers/ufs/host/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/ufs/host/Kconfig b/drivers/ufs/host/Kconfig
> index 4cc2dbd79ed0..f9786f085b54 100644
> --- a/drivers/ufs/host/Kconfig
> +++ b/drivers/ufs/host/Kconfig
> @@ -71,6 +71,7 @@ config SCSI_UFS_QCOM
>  config SCSI_UFS_MEDIATEK
>  	tristate "Mediatek specific hooks to UFS controller platform driver"
>  	depends on SCSI_UFSHCD_PLATFORM && ARCH_MEDIATEK
> +	select PM

Forcing a dependency is only valid if the driver won't work without it. PM is
an optional feature, so it shouldn't be forced. Moreover, in your case the
drivers were not used but instead erroring out because their definitions exist.

Here you should guard the ufs_mtk_runtime_suspend and ufs_mtk_runtime_resume
functions with CONFIG_PM instead.

Thanks,
Mani

>  	select PHY_MTK_UFS
>  	select RESET_TI_SYSCON
>  	help
> -- 
> 2.27.0
> 

-- 
மணிவண்ணன் சதாசிவம்