linux-kernel - Re: [PATCH] dt-bindings: mips: loongson: Add Loongson-1 based boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <926d3354-95c1-a6b0-38ad-f711c4ed6fe3@linaro.org>
Date:   Mon, 20 Feb 2023 13:36:49 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Keguang Zhang <keguang.zhang@...il.com>,
        linux-mips@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Jiaxun Yang <jiaxun.yang@...goat.com>
Subject: Re: [PATCH] dt-bindings: mips: loongson: Add Loongson-1 based boards

On 20/02/2023 12:30, Keguang Zhang wrote:
> Add two Loongson-1 based boards: LSGZ 1B and Smartloongson 1C.
> 
> Signed-off-by: Keguang Zhang <keguang.zhang@...il.com>
> ---
>  .../devicetree/bindings/mips/loongson/devices.yaml     | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mips/loongson/devices.yaml b/Documentation/devicetree/bindings/mips/loongson/devices.yaml
> index f13ce386f42c..6ed6e8d1c0a6 100644
> --- a/Documentation/devicetree/bindings/mips/loongson/devices.yaml
> +++ b/Documentation/devicetree/bindings/mips/loongson/devices.yaml
> @@ -37,6 +37,16 @@ properties:
>          items:
>            - const: loongson,loongson64v-4core-virtio
>  
> +      - description: LSGZ 1B Development Board
> +        items:
> +          - const: lsgz,1b

1. Undocumented vendor prefix
2. This should be rather enum as it will grow with more boards. Also
description could be rather - LS1B based boards.

> +          - const: loongson,ls1b
> +
> +      - description: Smart Loongson 1C Board
> +        items:
> +          - const: smartloongson,1c

Same comments.

> +          - const: loongson,ls1c
> +
>  additionalProperties: true
>  
>  ...
> 
> base-commit: 39459ce717b863556d7d75466fcbd904a6fbbbd8

Best regards,
Krzysztof