linux-kernel - Re: [PATCH v2 4/5] dt-bindings: mmc: sdhci-cadence: SD6 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 20 Feb 2023 14:48:57 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Piyush Malgujar <pmalgujar@...vell.com>
Cc:     linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
        adrian.hunter@...el.com, ulf.hansson@...aro.org,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        yamada.masahiro@...ionext.com, devicetree@...r.kernel.org,
        jannadurai@...vell.com, cchavva@...vell.com
Subject: Re: [PATCH v2 4/5] dt-bindings: mmc: sdhci-cadence: SD6 support

On 20/02/2023 14:22, Piyush Malgujar wrote:

>>> +
>>> +  cdns,read-dqs-cmd-delay:
>>> +    description: Command delay used in HS200 tuning
>>
>> What are the units?
>>
>>> +    $ref: "/schemas/types.yaml#/definitions/uint32"
>>
>> Drop quotes (everywhere)
>>
>>> +
>>> +  cdns,tune-val-start:
>>> +    description: Staring value of data delay used in HS200 tuning
>>
>> Same problem - missing units.
>>
> 
> These are integer values, will add in the description that these units are integer used
> in tuning. Also, will remove the $ref.

All units are integer values. We don't talk about this. Delay is usually
in time, thus I would assume here proper unit suffix.


Best regards,
Krzysztof