linux-kernel - Re: [PATCH] macintosh: windfarm: Use unsigned type for 1-bit bitfields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <167686495882.2406274.8062976789775517076.b4-ty@ellerman.id.au>
Date:   Mon, 20 Feb 2023 14:49:18 +1100
From:   Michael Ellerman <patch-notifications@...erman.id.au>
To:     Nathan Chancellor <nathan@...nel.org>, benh@...nel.crashing.org,
        mpe@...erman.id.au
Cc:     llvm@...ts.linux.dev, linux-kernel@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org, patches@...ts.linux.dev
Subject: Re: [PATCH] macintosh: windfarm: Use unsigned type for 1-bit bitfields

On Wed, 15 Feb 2023 10:12:12 -0700, Nathan Chancellor wrote:
> Clang warns:
> 
>   drivers/macintosh/windfarm_lm75_sensor.c:63:14: error: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion]
>                   lm->inited = 1;
>                              ^ ~
> 
>   drivers/macintosh/windfarm_smu_sensors.c:356:19: error: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion]
>                   pow->fake_volts = 1;
>                                   ^ ~
>   drivers/macintosh/windfarm_smu_sensors.c:368:18: error: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion]
>                   pow->quadratic = 1;
>                                  ^ ~
> 
> [...]

Applied to powerpc/next.

[1/1] macintosh: windfarm: Use unsigned type for 1-bit bitfields
      https://git.kernel.org/powerpc/c/748ea32d2dbd813d3bd958117bde5191182f909a

cheers