linux-kernel - Re: [PATCH v4 2/5] drivers: regulator: Add ADI MAX77541/MAX77540 Regulator Support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y/OR/pq8ene7sA2Z@smile.fi.intel.com>
Date:   Mon, 20 Feb 2023 17:30:06 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     "Sahin, Okan" <Okan.Sahin@...log.com>
Cc:     Mark Brown <broonie@...nel.org>, Lee Jones <lee@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
        William Breathitt Gray <william.gray@...aro.org>,
        ChiYuan Huang <cy_huang@...htek.com>,
        Marcus Folkesson <marcus.folkesson@...il.com>,
        Caleb Connolly <caleb.connolly@...aro.org>,
        "Bolboaca, Ramona" <Ramona.Bolboaca@...log.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>
Subject: Re: [PATCH v4 2/5] drivers: regulator: Add ADI MAX77541/MAX77540
 Regulator Support

On Mon, Feb 20, 2023 at 02:58:47PM +0000, Sahin, Okan wrote:
> Wed, 1 Feb 2023 5:30 PM
> Mark Brown <broonie@...nel.org> wrote:
> >On Wed, Feb 01, 2023 at 01:35:15PM +0300, Okan Sahin wrote:

> >Please submit patches using subject lines reflecting the style for the subsystem,
> >this makes it easier for people to identify relevant patches.
> >Look at what existing commits in the area you're changing are doing and make
> >sure your subject lines visually resemble what they're doing.
> >There's no need to resubmit to fix this alone.
> >
> >> +	if (max77541->chip->id == MAX77540)
> >> +		desc = max77540_regulators_desc;
> >> +	else if (max77541->chip->id == MAX77541)
> >> +		desc = max77541_regulators_desc;
> >> +	else
> >> +		return -EINVAL;
> >
> >Write this as a switch statement for extensibility.
> >
> >Otherwise this looks good.

> Thank you for your feedback.  I am not sure that I fully understand your
> feedback. What do you mean by "reflecting style for the subsystem". For
> example, this patch includes files modified or added under regulator
> directory as stated in the subject line. Do I need to say anything about mfd
> as regulator is subdevice?

It's about Subject.

Just run `git log --online --no-merges -- drivers/regulator/max77*` and
look closely at it.

-- 
With Best Regards,
Andy Shevchenko